Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Family View errors #50

Open
somini opened this issue Sep 19, 2015 · 8 comments
Open

Family View errors #50

somini opened this issue Sep 19, 2015 · 8 comments

Comments

@somini
Copy link
Owner

somini commented Sep 19, 2015

As reported on the Steam Forum
http://steamcommunity.com/groups/pixelvision2/discussions/0/523897653306957927/

Here's a screenshot:
ss

I dug into the code and I see "ParentalLockButton" it's defined here:
https://github.com/somini/Pixelvision2/blob/master/resource/layout/steamrootdialog.layout#L620

I changed the margin-right to 75 and got this.
When Parental Control is active, there's a small discrepancy in the username.
screenshot from 2015-09-19 15 31 04

@CaptainMagma
Copy link
Contributor

Unfortunately, I won't be able to look into this issue until either late tonight or tomorrow. I have a lot of work that I planned on completing today. If the issue has not been resolved by tonight, expect a pull request from me some time tomorrow in the afternoon.

@CaptainMagma
Copy link
Contributor

When I enable family view with default settings on PixelVision, the icon is in the correct position. Are you sure this error in positioning is not a result of switching fonts?

@somini
Copy link
Owner Author

somini commented Sep 20, 2015

Could be, I use the +3 font size tweak.

@CaptainMagma
Copy link
Contributor

Oh I see how this bug is happening. If you have no money in your Steam wallet, it doesn't get aligned right. I'll have a fix for this shortly.

@somini somini closed this as completed in ed2c144 Sep 24, 2015
@somini
Copy link
Owner Author

somini commented Nov 10, 2015

A new issue has cropped up, so I'm reopening this:
bug
When the wallet balance is too big, the Family View button overlaps it. It should be a matter of moving the button a dozen pixels to the left.

@somini somini reopened this Nov 10, 2015
@CaptainMagma
Copy link
Contributor

The location of the family view button does not change dynamically. The only thing I could do was change its static location. Since this is still a problem, all you can do is move further along the left or relocate it. You can try different locations if you want. I don't have time to look at this right now, sorry. This weekend I should be able to look at all the issues so far.

@Black4Blade
Copy link
Collaborator

Hey, can this topic be closed now seeing that they changed how the account balance and all is showing?
I will assume that will solve the issue for the wallet crashing into it (I don't have that much in my currency to see if it will clash, no idea if there is a way to fake add there)

@Bluscream
Copy link
Contributor

#50 (comment)

Sadly this will never happen to me ;c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants