From 700d118ed7c01bd70b03c47c190cc8d89023003f Mon Sep 17 00:00:00 2001
From: Nikita Melkozerov <nikita@some.engineering>
Date: Tue, 1 Oct 2024 09:28:51 +0000
Subject: [PATCH] linters and tests

---
 plugins/aws/fix_plugin_aws/access_edges.py | 25 +++++++++++-----------
 plugins/aws/test/acccess_edges_test.py     | 14 ++++++------
 2 files changed, 19 insertions(+), 20 deletions(-)

diff --git a/plugins/aws/fix_plugin_aws/access_edges.py b/plugins/aws/fix_plugin_aws/access_edges.py
index bee70fb540..94509cc609 100644
--- a/plugins/aws/fix_plugin_aws/access_edges.py
+++ b/plugins/aws/fix_plugin_aws/access_edges.py
@@ -472,19 +472,18 @@ def get_action_level(action: str) -> PermissionLevel:
             if action == info["action"]:
                 level = info["access_level"]
                 break
-    match level:
-        case "List":
-            return PermissionLevel.List
-        case "Read":
-            return PermissionLevel.Read
-        case "Tagging":
-            return PermissionLevel.Tagging
-        case "Write":
-            return PermissionLevel.Write
-        case "Permissions management":
-            return PermissionLevel.PermissionManagement
-        case _:
-            return PermissionLevel.Unknown
+    if level == "List":
+        return PermissionLevel.List
+    elif level == "Read":
+        return PermissionLevel.Read
+    elif level == "Tagging":
+        return PermissionLevel.Tagging
+    elif level == "Write":
+        return PermissionLevel.Write
+    elif level == "Permissions management":
+        return PermissionLevel.PermissionManagement
+    else:
+        return PermissionLevel.Unknown
 
 
 # logic according to https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_evaluation-logic.html
diff --git a/plugins/aws/test/acccess_edges_test.py b/plugins/aws/test/acccess_edges_test.py
index 1d02af4453..e5a4ad0266 100644
--- a/plugins/aws/test/acccess_edges_test.py
+++ b/plugins/aws/test/acccess_edges_test.py
@@ -16,7 +16,7 @@
     compute_permissions,
 )
 
-from fixlib.baseresources import PolicySourceKind, PolicySource
+from fixlib.baseresources import PolicySourceKind, PolicySource, PermissionLevel
 from fixlib.json import to_json_str
 
 
@@ -390,7 +390,7 @@ def test_compute_permissions_user_inline_policy_allow() -> None:
     permissions = compute_permissions(resource=bucket, iam_context=request_context, resource_based_policies=[])
     assert len(permissions) == 1
     assert permissions[0].action == "s3:ListBucket"
-    assert permissions[0].level == "List"
+    assert permissions[0].level == PermissionLevel.List
     assert len(permissions[0].scopes) == 1
     s = permissions[0].scopes[0]
     assert s.source.kind == PolicySourceKind.Principal
@@ -429,7 +429,7 @@ def test_compute_permissions_user_inline_policy_allow_with_conditions() -> None:
     permissions = compute_permissions(resource=bucket, iam_context=request_context, resource_based_policies=[])
     assert len(permissions) == 1
     assert permissions[0].action == "s3:ListBucket"
-    assert permissions[0].level == "List"
+    assert permissions[0].level == PermissionLevel.List
     assert len(permissions[0].scopes) == 1
     s = permissions[0].scopes[0]
     assert s.source.kind == PolicySourceKind.Principal
@@ -644,7 +644,7 @@ def test_deny_overrides_allow_with_condition() -> None:
     assert len(permissions) == 1
     p = permissions[0]
     assert p.action == "s3:ListBucket"
-    assert p.level == "List"
+    assert p.level == PermissionLevel.List
     assert len(p.scopes) == 1
     s = p.scopes[0]
     assert s.source.kind == PolicySourceKind.Principal
@@ -687,7 +687,7 @@ def test_compute_permissions_resource_based_policy_allow() -> None:
     assert len(permissions) == 1
     p = permissions[0]
     assert p.action == "s3:ListBucket"
-    assert p.level == "List"
+    assert p.level == PermissionLevel.List
     assert len(p.scopes) == 1
     s = p.scopes[0]
     assert s.source.kind == PolicySourceKind.Resource
@@ -744,7 +744,7 @@ def test_compute_permissions_permission_boundary_restrict() -> None:
     assert len(permissions) == 1
     p = permissions[0]
     assert p.action == "s3:ListBucket"
-    assert p.level == "List"
+    assert p.level == PermissionLevel.List
     assert len(p.scopes) == 1
     s = p.scopes[0]
     assert s.source.kind == PolicySourceKind.Principal
@@ -823,7 +823,7 @@ def test_compute_permissions_user_with_group_policies() -> None:
     assert len(permissions) == 1
     p = permissions[0]
     assert p.action == "s3:ListBucket"
-    assert p.level == "List"
+    assert p.level == PermissionLevel.List
     assert len(p.scopes) == 1
     s = p.scopes[0]
     assert s.source.kind == PolicySourceKind.Group