Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Modal should open in place and load edit form remotely #6015

Open
tvdeyen opened this issue Dec 6, 2024 · 0 comments
Open

[Admin] Modal should open in place and load edit form remotely #6015

tvdeyen opened this issue Dec 6, 2024 · 0 comments

Comments

@tvdeyen
Copy link
Member

tvdeyen commented Dec 6, 2024

Final comment from #6014

So, what we would need to do is open the modal on click and display the result from the edit route. This is exactly what we do in Alchemy and this is very successful, fast (because we do not reload the table displayed under the modal, just the form), semantic and even tests work without JS enabled.

I could port this over to Solidus, but there is much more involved, because currently the admin is build to open the modal on the edit page and redisplaying the whole table. Which is painful for performance, but this is how things are implemented and fixing that will cost more time than I am willing to invest right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant