From a4677fa5a7dd60c9dd42460936f42c8a9487bffd Mon Sep 17 00:00:00 2001
From: Thomas von Deyen <thomas@vondeyen.com>
Date: Thu, 5 Dec 2024 08:28:26 +0100
Subject: [PATCH] tests: Give dialogs a little more time to open

The default time of 2 seconds is not enough sometimes.
Give it 3 more seconds to wait until Capybara raises an
error.

(cherry picked from commit a30d802dc496ba7199fba4ff2c92d46054097ce3)
---
 admin/spec/features/adjustment_reasons_spec.rb   | 4 ++--
 admin/spec/features/return_reasons_spec.rb       | 4 ++--
 admin/spec/features/roles_spec.rb                | 4 ++--
 admin/spec/features/store_credit_reasons_spec.rb | 4 ++--
 admin/spec/features/tax_categories_spec.rb       | 2 +-
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/admin/spec/features/adjustment_reasons_spec.rb b/admin/spec/features/adjustment_reasons_spec.rb
index 14499858cf..5d663b7bd1 100644
--- a/admin/spec/features/adjustment_reasons_spec.rb
+++ b/admin/spec/features/adjustment_reasons_spec.rb
@@ -26,7 +26,7 @@
     before do
       visit "/admin/adjustment_reasons#{query}"
       click_on "Add new"
-      expect(page).to have_selector("dialog")
+      expect(page).to have_selector("dialog", wait: 5)
       expect(page).to have_content("New Adjustment Reason")
       expect(page).to be_axe_clean
     end
@@ -69,7 +69,7 @@
       Spree::AdjustmentReason.create(name: "Good Reason", code: 5999)
       visit "/admin/adjustment_reasons#{query}"
       find_row("Good Reason").click
-      expect(page).to have_selector("dialog")
+      expect(page).to have_selector("dialog", wait: 5)
       expect(page).to have_content("Edit Adjustment Reason")
       expect(page).to be_axe_clean
     end
diff --git a/admin/spec/features/return_reasons_spec.rb b/admin/spec/features/return_reasons_spec.rb
index 706d916674..46e2287509 100644
--- a/admin/spec/features/return_reasons_spec.rb
+++ b/admin/spec/features/return_reasons_spec.rb
@@ -26,7 +26,7 @@
     before do
       visit "/admin/return_reasons#{query}"
       click_on "Add new"
-      expect(page).to have_selector("dialog")
+      expect(page).to have_selector("dialog", wait: 5)
       expect(page).to have_content("New Return Reason")
       expect(page).to be_axe_clean
     end
@@ -68,7 +68,7 @@
       Spree::ReturnReason.create(name: "Good Reason")
       visit "/admin/return_reasons#{query}"
       find_row("Good Reason").click
-      expect(page).to have_selector("dialog")
+      expect(page).to have_selector("dialog", wait: 5)
       expect(page).to have_content("Edit Return Reason")
       expect(page).to be_axe_clean
     end
diff --git a/admin/spec/features/roles_spec.rb b/admin/spec/features/roles_spec.rb
index fb09c9894e..c50e6acd13 100644
--- a/admin/spec/features/roles_spec.rb
+++ b/admin/spec/features/roles_spec.rb
@@ -54,7 +54,7 @@
     before do
       visit "/admin/roles#{query}"
       click_on "Add new"
-      expect(page).to have_selector("dialog")
+      expect(page).to have_selector("dialog", wait: 5)
       expect(page).to have_content("New Role")
       expect(page).to be_axe_clean
     end
@@ -121,7 +121,7 @@
       Spree::Role.create(name: "Reviewer", permission_sets: [settings_edit_permission])
       visit "/admin/roles#{query}"
       find_row("Reviewer").click
-      expect(page).to have_selector("dialog")
+      expect(page).to have_selector("dialog", wait: 5)
       expect(page).to have_content("Edit Role")
       expect(page).to be_axe_clean
       expect(Spree::Role.find_by(name: "Reviewer").permission_set_ids)
diff --git a/admin/spec/features/store_credit_reasons_spec.rb b/admin/spec/features/store_credit_reasons_spec.rb
index 50b2c11d02..697dc00dd9 100644
--- a/admin/spec/features/store_credit_reasons_spec.rb
+++ b/admin/spec/features/store_credit_reasons_spec.rb
@@ -26,7 +26,7 @@
     before do
       visit "/admin/store_credit_reasons#{query}"
       click_on "Add new"
-      expect(page).to have_selector("dialog")
+      expect(page).to have_selector("dialog", wait: 5)
       expect(page).to have_content("New Store Credit Reason")
       expect(page).to be_axe_clean
     end
@@ -66,7 +66,7 @@
       Spree::StoreCreditReason.create(name: "New Customer Reward")
       visit "/admin/store_credit_reasons#{query}"
       find_row("New Customer Reward").click
-      expect(page).to have_selector("dialog")
+      expect(page).to have_selector("dialog", wait: 5)
       expect(page).to have_content("Edit Store Credit Reason")
       expect(page).to be_axe_clean
     end
diff --git a/admin/spec/features/tax_categories_spec.rb b/admin/spec/features/tax_categories_spec.rb
index 417ee5e126..abf26eff14 100644
--- a/admin/spec/features/tax_categories_spec.rb
+++ b/admin/spec/features/tax_categories_spec.rb
@@ -28,7 +28,7 @@
     before do
       visit "/admin/tax_categories#{query}"
       click_on "Add new"
-      expect(page).to have_selector("dialog")
+      expect(page).to have_selector("dialog", wait: 5)
       expect(page).to have_content("New Tax Category")
       expect(page).to be_axe_clean
     end