From 59c174e52d99f7efb1d34c316664e17d5e2d2b4b Mon Sep 17 00:00:00 2001 From: Martin Meyerhoff Date: Thu, 18 Apr 2024 11:23:34 +0200 Subject: [PATCH] Restrict sqlite3 for the extension generator The task itself is fine, as it inherits from Rails' app generator, which has the sqlite3 restriction: https://github.com/rails/rails/blob/main/railties/lib/rails/generators/database.rb#L19. (cherry picked from commit e85fd4cd7300b1e8f4f5f142cc6f5d41003ca23e) # Conflicts: # .circleci/config.yml --- .circleci/config.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index a522d743806..5b676d63140 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -222,7 +222,9 @@ commands: mkdir -p /tmp/dummy_extension cd /tmp/dummy_extension bundle init - bundle add rails sqlite3 <> --skip-install + bundle add rails -v "< 7.1" --skip-install + bundle add sqlite3 -v "~> 1.3" --skip-install + test -n "<>" && bundle add <> --skip-install bundle add solidus --path "$(ruby -e"puts File.expand_path ENV['CIRCLE_WORKING_DIRECTORY']")" export LIB_NAME=set # dummy requireable file bundle exec rake -rrails -rspree/testing_support/extension_rake -e'Rake::Task["extension:test_app"].invoke'