From 590a7ac020ca85e4610f0f80575aff540cd8199a Mon Sep 17 00:00:00 2001
From: Michela Frecchiami <michelafrecchiami@nebulab.it>
Date: Fri, 13 Oct 2023 10:11:16 +0200
Subject: [PATCH] Hints update

Hints that display in tooltip have to be clear and concise. Fields that
might have a critical effect to product creation are always visible
under the field. Hints that don't give relevant suggestions, have been
removed.
---
 .../solidus_admin/products/show/component.html.erb     |  6 +++---
 .../solidus_admin/products/show/component.yml          | 10 +++++-----
 .../ui/panel/component_preview/overview.html.erb       |  6 +++---
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/admin/app/components/solidus_admin/products/show/component.html.erb b/admin/app/components/solidus_admin/products/show/component.html.erb
index dba38b84824..c16435fe637 100644
--- a/admin/app/components/solidus_admin/products/show/component.html.erb
+++ b/admin/app/components/solidus_admin/products/show/component.html.erb
@@ -41,7 +41,7 @@
           <%= render component("ui/forms/field").text_area(f, :description) %>
         <% end %>
 
-        <%= render component('ui/panel').new(title: 'SEO', title_hint: 'Search Engine Optimization') do %>
+        <%= render component('ui/panel').new(title: 'SEO') do %>
           <%= render component("ui/forms/field").text_field(f, :meta_title) %>
           <%= render component("ui/forms/field").text_field(f, :meta_description) %>
           <%= render component("ui/forms/field").text_area(f, :meta_keywords) %>
@@ -109,8 +109,8 @@
 
       <aside class="justify-center items-start gap-4 flex flex-col w-full max-w-sm">
         <%= render component('ui/panel').new(title: "Publishing") do %>
-          <%= render component("ui/forms/field").text_field(f, :available_on, tip: t(".hints.available_on_html"), type: :date) %>
-          <%= render component("ui/forms/field").text_field(f, :discontinue_on, tip: t(".hints.discontinue_on_html"), type: :date) %>
+          <%= render component("ui/forms/field").text_field(f, :available_on, hint: t(".available_on_html"), type: :date) %>
+          <%= render component("ui/forms/field").text_field(f, :discontinue_on, hint: t(".discontinue_on_html"), type: :date) %>
 
           <label class="flex gap-2 items-center">
             <%= render component("ui/forms/checkbox").new(
diff --git a/admin/app/components/solidus_admin/products/show/component.yml b/admin/app/components/solidus_admin/products/show/component.yml
index d7643794f59..4b680f81c2f 100644
--- a/admin/app/components/solidus_admin/products/show/component.yml
+++ b/admin/app/components/solidus_admin/products/show/component.yml
@@ -9,9 +9,9 @@ en:
   manage_properties: "Manage product specifications"
   manage_stock: "Manage stock"
   delete_confirmation: "Are you sure you want to delete this product?"
+  available_on_html: 'Product availability starts from the set date.<br> Empty date indicates no availability.'
+  discontinue_on_html: 'Product availability ends from the set date.<br> Empty date indicates continuous availability.'
   hints:
-    available_on_html: This sets the availability date for the product. If this value is not set, or it is set to a date in the future, then the product is not available on the storefront.
-    discontinue_on_html: This sets the discontinue date for the product. If this value is set to a date, then the product is not available on the storefront from that day on anymore.
-    promotionable_html: 'This determines whether or not promotions can apply to this product.<br>Default: Checked'
-    shipping_category_html: 'This determines what kind of shipping this product requires.<br> Default: Default'
-    tax_category_html: 'This determines what kind of taxation is applied to this product.<br> Default: %{default_tax_category}'
+    promotionable_html: Promotions can apply to this product
+    shipping_category_html: Manage Shipping in Settings
+    tax_category_html: Manage Taxes in Settings
diff --git a/admin/spec/components/previews/solidus_admin/ui/panel/component_preview/overview.html.erb b/admin/spec/components/previews/solidus_admin/ui/panel/component_preview/overview.html.erb
index 8c7c751c338..36976757baf 100644
--- a/admin/spec/components/previews/solidus_admin/ui/panel/component_preview/overview.html.erb
+++ b/admin/spec/components/previews/solidus_admin/ui/panel/component_preview/overview.html.erb
@@ -29,7 +29,7 @@
     With title and hint
   </h6>
 
-  <%= render current_component.new(title: "SEO", title_hint: "Search Engine Optimization") do %>
+  <%= render current_component.new(title: "SEO") do %>
     <label>
       SKU:
       ABC-123
@@ -42,7 +42,7 @@
     With title, hint, and actions
   </h6>
 
-  <%= render current_component.new(title: "SEO", title_hint: "Search Engine Optimization") do |panel| %>
+  <%= render current_component.new(title: "SEO") do |panel| %>
     <label>
       SKU:
       ABC-123
@@ -57,7 +57,7 @@
     With no content
   </h6>
 
-  <%= render current_component.new(title: "SEO", title_hint: "Search Engine Optimization") do |panel| %>
+  <%= render current_component.new(title: "SEO") do |panel| %>
     <% panel.with_action(name: "Foo", href: "#foo") %>
   <% end %>
 </div>