From 3f18f814896c613d959e8ea8accb4ba26b0c6a36 Mon Sep 17 00:00:00 2001 From: Rainer Dema Date: Mon, 23 Oct 2023 18:20:37 +0200 Subject: [PATCH] Remove redundant feedback component in `Orders` & `Products` tables Eliminated an unnecessary double rendering of the feedback component in both the Orders and Products tables. This change leverages the `page_header_actions` helper, aligning with the updates in https://github.com/solidusio/solidus/pull/5445. --- .../app/components/solidus_admin/orders/index/component.html.erb | 1 - admin/app/components/solidus_admin/orders/new/component.html.erb | 1 - .../components/solidus_admin/products/index/component.html.erb | 1 - 3 files changed, 3 deletions(-) diff --git a/admin/app/components/solidus_admin/orders/index/component.html.erb b/admin/app/components/solidus_admin/orders/index/component.html.erb index 17d95a59fbd..6539a00b9e7 100644 --- a/admin/app/components/solidus_admin/orders/index/component.html.erb +++ b/admin/app/components/solidus_admin/orders/index/component.html.erb @@ -5,7 +5,6 @@
- <%= render component("feedback").new %> <%= render component("ui/button").new( tag: :a, text: t('.create_order'), diff --git a/admin/app/components/solidus_admin/orders/new/component.html.erb b/admin/app/components/solidus_admin/orders/new/component.html.erb index 37a13c33309..350c9362d24 100644 --- a/admin/app/components/solidus_admin/orders/new/component.html.erb +++ b/admin/app/components/solidus_admin/orders/new/component.html.erb @@ -5,7 +5,6 @@ <%= page_header_title t(".create_order") %> <%= page_header_actions do %> - <%= render component("feedback").new %> <%= render component("ui/button").new(tag: :button, scheme: :secondary, text: t(".discard"), form: form_id) %> <%= render component("ui/button").new(tag: :button, text: t(".save"), form: form_id) %> <% end %> diff --git a/admin/app/components/solidus_admin/products/index/component.html.erb b/admin/app/components/solidus_admin/products/index/component.html.erb index b35b6ff4fb4..5eee57b7229 100644 --- a/admin/app/components/solidus_admin/products/index/component.html.erb +++ b/admin/app/components/solidus_admin/products/index/component.html.erb @@ -2,7 +2,6 @@ <%= page_header do %> <%= page_header_title title %> <%= page_header_actions do %> - <%= render component("feedback").new %> <%= render component("ui/button").new( tag: :a, text: t('.add_product'),