From 199dd69297b0b120fbea2ef1cc2699eef8b4467a Mon Sep 17 00:00:00 2001 From: Ryan Carniato Date: Thu, 14 Nov 2024 14:43:13 -0800 Subject: [PATCH] fix reconcile null guard --- .changeset/fresh-apricots-remain.md | 5 +++++ packages/solid/store/src/modifiers.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/fresh-apricots-remain.md diff --git a/.changeset/fresh-apricots-remain.md b/.changeset/fresh-apricots-remain.md new file mode 100644 index 000000000..3a23578af --- /dev/null +++ b/.changeset/fresh-apricots-remain.md @@ -0,0 +1,5 @@ +--- +"solid-js": patch +--- + +fix reconcile null guard diff --git a/packages/solid/store/src/modifiers.ts b/packages/solid/store/src/modifiers.ts index 6f62f43f3..e7eae20c3 100644 --- a/packages/solid/store/src/modifiers.ts +++ b/packages/solid/store/src/modifiers.ts @@ -54,7 +54,7 @@ function applyState( end >= start && newEnd >= start && (previous[end] === target[newEnd] || - (key && previous[start] && target[start] && previous[end][key] === target[newEnd][key])); + (key && previous[end] && target[newEnd] && previous[end][key] === target[newEnd][key])); end--, newEnd-- ) { temp[newEnd] = previous[end];