Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor readability issue with filenames of test resources #33

Open
edwardsph opened this issue Feb 26, 2021 · 2 comments
Open

Minor readability issue with filenames of test resources #33

edwardsph opened this issue Feb 26, 2021 · 2 comments

Comments

@edwardsph
Copy link
Contributor

The read*, update and delete tests use test.txt when setting up turtle resources. Elsewhere it is test.ttl.
It doesn't affect whether or not the tests work but might help readability if the filenames were consistent with the content types.

@bourgeoa
Copy link
Member

bourgeoa commented Mar 3, 2021

We may consider that these tests are doing 2 things at the same time and that it is OK
or relabel them to explicitly state that they update/delete resources with filenames ending with a different media type then the content-type,
or add tests so that they do only one thing at a time

@edwardsph
Copy link
Contributor Author

Personally, I think for traceability reasons a test should focus on one thing at a time. I suspect the filename difference was a simple copy & paste oversight in this case not a deliberate purpose of the test. Each test should be clear about its purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants