Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-97728: make default token available in workflow environment #287

Merged
merged 1 commit into from
Dec 9, 2024
Merged

NH-97728: make default token available in workflow environment #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ permissions:
env:
GITHUB_USERNAME: ${{ github.actor }}
PROD_BUCKET: ${{ secrets.PROD_BUCKET }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

jobs:
maven_release:
Expand All @@ -52,7 +53,6 @@ jobs:
- name: Publish
run: ./gradlew publishToSonatype closeAndReleaseSonatypeStagingRepository
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# The secrets are for publishing the build artifacts to the Maven Central.
SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }}
SONATYPE_TOKEN: ${{ secrets.SONATYPE_TOKEN }}
Expand Down Expand Up @@ -117,8 +117,6 @@ jobs:

upload_file_to_release "$release_id" "agent/build/libs/solarwinds-apm-agent.jar"
upload_file_to_release "$release_id" "custom/shared/src/main/resources/solarwinds-apm-config.json"
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

s3-prod-upload: # this job uploads the jar and default config json to prod s3
if: inputs.run_s3_upload
Expand Down Expand Up @@ -384,7 +382,6 @@ jobs:
upload_file_to_release "$release_id" "agent/build/libs/solarwinds-apm-agent-signed.jar"

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
VERSION: ${{ steps.set_version.outputs.version }}

docker_hub:
Expand Down
Loading