Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Gate: Removing unwanted rounding in fee calculation #34982

Open
tao-stones opened this issue Jan 27, 2024 · 0 comments
Open

Feature Gate: Removing unwanted rounding in fee calculation #34982

tao-stones opened this issue Jan 27, 2024 · 0 comments
Labels
feature-gate Pull Request adds or modifies a runtime feature gate

Comments

@tao-stones
Copy link
Contributor

tao-stones commented Jan 27, 2024 •
edited
Loading

SIMD

none

Description

A carry-over: transaction fee is converted to f64, then round() then convert back to u64. This is unnecessary, and rounding large f64 isn't accurate since f64 has precision of 53 binary digits (eg 2^53).

The conversion and rounding should be removed, but since it'd result different transaction fee is value is large enough, this change needs feature gate.

Feature ID

BtVN7YjDzNE6Dk7kTT7YTDgMNUZTNgiSJgsdzAeTg2jF

Activation Method

Single Core Contributor

Deployment Considerations

none

Minimum Beta Version

2.0.0

Minimum Stable Version

No response

Testnet Activation Epoch

715

Devnet Activation Epoch

No response

Mainnet-Beta Activation Epoch

No response
@tao-stones tao-stones added the feature-gate Pull Request adds or modifies a runtime feature gate label Jan 27, 2024
@tao-stones tao-stones mentioned this issue Jan 27, 2024
Closed
This was referenced Feb 22, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tao-stones