Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOS] headerLargeTitle: true with headerBackTitleVisible: false makes back button animation jerky #2548

Open
iliapnmrv opened this issue Dec 4, 2024 · 4 comments
Assignees
Labels
Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided

Comments

@iliapnmrv
Copy link

Description

It is a copy of issue from here as it was labeled as react-native-screens
react-navigation/react-navigation#11946. Issue is half a year old but it persists even on newer versions of react-native-screens.

https://github.com/iliapnmrv/rn-navigation-headerLargeTitle-bug

Steps to reproduce

the video is pretty much self-explainatory
only setting headerBackTitleVisible: true resolves the issue

323551377-3ba2005f-e2c2-4009-ae67-adf654c010d4.mp4
323551060-81dd3690-45f1-4e1d-b0b8-41b71a602c8a.mp4

Snack or a link to a repository

https://snack.expo.dev/@iliapnmrv/headerlargetitle_headerbacktitlevisible

Screens version

3.30.1, 4.0.0

React Native version

0.75.4

Platforms

iOS

JavaScript runtime

None

Workflow

React Native (without Expo)

Architecture

Paper (Old Architecture)

Build type

None

Device

iOS simulator

Device model

No response

Acknowledgements

Yes

@github-actions github-actions bot added Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided labels Dec 4, 2024
@hirbod
Copy link
Contributor

hirbod commented Dec 5, 2024

This bug is also related to #2548

@kkafar
Copy link
Member

kkafar commented Dec 17, 2024

@iliapnmrv hey, thanks for reporting. I confirm that the issue is reproducible. Do you have any idea when the bug was introduced?

@kkafar kkafar self-assigned this Dec 17, 2024
@kkafar
Copy link
Member

kkafar commented Dec 17, 2024

Initial debugging notes (for future me): setting headerBackButtonDisplayMode: 'minimal' results in backButtonItem being customised (overriden by our custom instance), while default options stay with the UIKit created instance. When we override the instance the problem with "jumping button" arises.

Additional note: setting headerBackButtonDisplayMode: 'minimal' in JS does not result in appropriate value being received on native side - it changes headerBackButtonTitleVisible prop value to false, however the displayMode remains default. Need to take a look what react-navigation does there.

@iliapnmrv
Copy link
Author

@kkafar Hey! Unfortunately no, I just wanted to implement the feature and it did not work from the start, so I created an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided
Projects
None yet
Development

No branches or pull requests

3 participants