Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

container logs does not work if tty is enabled #295

Open
cswinter opened this issue May 20, 2021 · 1 comment
Open

container logs does not work if tty is enabled #295

cswinter opened this issue May 20, 2021 · 1 comment

Comments

@cswinter
Copy link
Contributor

When querying logs for containers with a tty, the logs stream is not multiplexed via headers but just returns the raw output: https://github.com/docker/cli/blob/86e1f04b5f115fb0b4bbd51e0e4a68233072d24b/vendor/github.com/docker/docker/client/container_logs.go#L19
The current logs implementation will parse random STDOUT data as a length header and then tries to perform a read_exact with usually an unreasonably large length which runs into EOF error. The observed behavior is that logs immediately exits without returning any output.
@cswinter cswinter mentioned this issue May 20, 2021
Open
@cswinter
Copy link
Contributor Author

Identical issue encountered by docker-py: docker/docker-py#630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cswinter