Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize video and image capture #3

Open
10 tasks
blakeNaccarato opened this issue Apr 11, 2023 · 0 comments
Open
10 tasks

Generalize video and image capture #3

blakeNaccarato opened this issue Apr 11, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@blakeNaccarato
Copy link
Member

The captures module currently serves boilercv with some module-level constants as defaults and a particular filename scheme. Generalize this approach somewhat, while keeping some sensible defaults (e.g. video format).

  • Optimize scale_bool and determine when it is necessary
  • Generalize file writing for only MP4 (pyav plugin), TIFF (tifffile_v3 plugin), and PNG (Pillow plugin). Use the v3 API and imopen in the refactor. Allow arguments to be passed through to override behavior, but choose reasonable defaults.
  • Do not manipulate paths by default, nor append timestamps. Just raise on improper extension/setting combinations
  • Generalize preview_frame behavior to preview arbitrary frames
  • Handle boolean-valued arrays consistently in previewing/capturing with scale_bool
  • Factor out common compositions of previews/captures to a third module. For example, previewing and capturing at once
  • Implement import-time configuration by the consumer with preview/capture flags
@blakeNaccarato blakeNaccarato added the enhancement New feature or request label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant