PERF/API: Drop in-place link_df() #333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized that this reverses #293 and does not handle empty frames. Sorry I forgot about that. I think that means we need more tests. |
|
This is superseded by #442. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the ability to link a DataFrame in-place. The only API change is to remove the
copy_featuresoption tolink_df(). The corresponding test was removed as well.link_df()now wrapslink_df_iter(), with some basic (and hopefully well-optimized) one-time Pandas operations on the input and output. This code is not very optimized, but it is lightweight and hopefully avoids the present N^2 performance bug.Does this close #294 ? Probably, but some simple performance scaling checks would be wise. I'll see if I can get around to it.