Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hessian logger config use wrong path and internal logger #78

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

JervyShi
Copy link
Member

@JervyShi JervyShi commented Jun 9, 2022

Fix #77

Change logger namespace from com.alipay.sofa.middleware.config to com.alipay.sofa.hessian.

Fix log4j config use internal Appender class.

@JervyShi JervyShi requested a review from OrezzerO June 9, 2022 09:41
@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes size/L labels Jun 9, 2022
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #78 (22fd9a1) into 3.x (a71bc56) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              3.x      #78      +/-   ##
==========================================
+ Coverage   26.06%   26.12%   +0.05%     
==========================================
  Files         158      158              
  Lines       11129    11129              
  Branches     1980     1980              
==========================================
+ Hits         2901     2907       +6     
+ Misses       7930     7927       -3     
+ Partials      298      295       -3     
Impacted Files Coverage Δ
...n/java/com/alipay/hessian/NameBlackListFilter.java 62.50% <ø> (ø)
...main/java/com/caucho/hessian/io/Hessian2Input.java 32.49% <0.00%> (+0.12%) ⬆️
.../com/alipay/hessian/generic/util/GenericUtils.java 82.17% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a71bc56...22fd9a1. Read the comment docs.

@JervyShi JervyShi added this to the 3.4.0 milestone Jun 9, 2022
Copy link
Contributor

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JervyShi JervyShi merged commit fc4a518 into sofastack:3.x Jun 15, 2022
@JervyShi JervyShi deleted the fix-log4j-error branch June 15, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants