Fix type forward declaration in the bindings #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nows about them. The problem: Depending on the definition order of the binded classes, there may have incorrect types if Base is useing BaseData... but BaseData is only binded after Base. The PR propose a solution for that using a decidcated "forward" registration patter.
damienmarchal
added
pr: status to review
pr: experimental
pr: clean-fix
and removed
pr: experimental
labels
hugtalbot
changed the title
…-how-to-fix-definition
…definition' into pr-typehint-example-how-to-fix-definition
It should be completed if ones want more feature than just class declaration
…-how-to-fix-definition
|
Rebased and passing tests. |
Merged
|
PR looks clean 👍 but I would need some insight (the link with #456) |
…-how-to-fix-definition
|
In #456 was a preliminary version of the current one on BaseData. The current PR covers the whole plugin. So to me it is to merge if CI pass. |
damienmarchal
changed the title
bakpaul
approved these changes
Dec 6, 2024
alxbilger
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
Depending on the definition order of the binded classes, binding "Base", and BaseData registered after then the use of BaseData in the function signature in Base will have invalid string name. This prevent stubgen to make their work.
In the PR I propose a way to fix that.