From c8fd84db7f6a288fb9839e80d9115ac1ad90e076 Mon Sep 17 00:00:00 2001 From: Azouaou Ouyoucef Date: Thu, 12 Sep 2024 17:18:05 +0200 Subject: [PATCH 1/3] Bump actions/download-artifact from 2 to 4.1.7 --- .github/workflows/ci.yml | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fa4e72b..baa8c5a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -126,17 +126,29 @@ jobs: make install fi + - name: Sanitize artifact name + id: sanitize + # This step removes special characters from the artifact name to ensure compatibility with upload-artifact + # Characters removed: " : < > | * ? \r \n \ / + # Spaces are replaced with underscores + # This sanitization prevents errors in artifact creation and retrieval + shell: pwsh + run: | + $originalName = "Optimus_${{ steps.sofa.outputs.run_branch }}_for-SOFA-${{ steps.sofa.outputs.sofa_version }}_${{ runner.os }}" + $artifact_name = $originalName -replace '[":;<>|*?\r\n\\/]', '' -replace ' ', '_' + echo "artifact_name=$artifact_name" >> $env:GITHUB_OUTPUT + - name: Create artifact - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4.4.0 with: - name: Optimus_${{ steps.sofa.outputs.run_branch }}_for-SOFA-${{ steps.sofa.outputs.sofa_version }}_${{ runner.os }} - path: ${{ github.workspace }}/build_release/install + name: ${{ steps.sanitize.outputs.artifact_name }} + path: ${{ env.WORKSPACE_INSTALL_PATH }} - name: Install artifact - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v4.1.7 with: - name: Optimus_${{ steps.sofa.outputs.run_branch }}_for-SOFA-${{ steps.sofa.outputs.sofa_version }}_${{ runner.os }} - path: ${{ github.workspace }}/build_release/install + name: ${{ steps.sanitize.outputs.artifact_name }} + path: ${{ env.WORKSPACE_ARTIFACT_PATH }} - name: Optimus tests shell: bash From 18f4f6795d4c535b24909299bc1a9347c50e30c2 Mon Sep 17 00:00:00 2001 From: Paul Baksic <30337881+bakpaul@users.noreply.github.com> Date: Mon, 16 Sep 2024 09:55:36 +0200 Subject: [PATCH 2/3] Update dosnload-artifact version in Deploy Artifacts --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index baa8c5a..f93420a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -183,7 +183,7 @@ jobs: continue-on-error: true steps: - name: Get artifacts - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v4.1.7 with: path: artifacts From 43a3f49272a753ea8c5ff1d0e84ab43ab66518a1 Mon Sep 17 00:00:00 2001 From: Paul Baksic <30337881+bakpaul@users.noreply.github.com> Date: Mon, 16 Sep 2024 11:21:04 +0200 Subject: [PATCH 3/3] Try fix artifact creation --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f93420a..5c6af90 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -116,12 +116,13 @@ jobs: && cmd //c "${{ steps.sofa.outputs.vs_vsdevcmd }} \ && cd /d $GITHUB_WORKSPACE/build_release \ && cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DUSE_BLAS_FOR_OPTIMUS=0 \ + -DCMAKE_INSTALL_PREFIX=${{ env.WORKSPACE_INSTALL_PATH }} \ -DCMAKE_PREFIX_PATH="$SOFA_ROOT/build_release/install";$EIGEN_INSTALL_DIR/build_release .. \ && ninja install" else mkdir $GITHUB_WORKSPACE/build_release cd $GITHUB_WORKSPACE/build_release - cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_PREFIX_PATH=$SOFA_ROOT/build_release/install .. + cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=${{ env.WORKSPACE_INSTALL_PATH }} -DCMAKE_PREFIX_PATH=$SOFA_ROOT/build_release/install .. make -j 8 make install fi