Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering in MapEntries #364

Open
stefaanv opened this issue Nov 20, 2023 · 2 comments
Open

Allow filtering in MapEntries #364

stefaanv opened this issue Nov 20, 2023 · 2 comments

Comments

@stefaanv
Copy link

If the mapEntries() code is updates as below, it's function would extend to filtering the properties of the object

const mapEntries = <
    TKey extends string | number | symbol,
    TValue,
    TNewKey extends string | number | symbol,
    TNewValue,
>(
    obj: Record<TKey, TValue>,
    toEntry: (key: TKey, value: TValue) => [TNewKey, TNewValue] | undefined
): Record<TNewKey, TNewValue> => {
    if (!obj) return {} as Record<TNewKey, TNewValue>
    return Object.entries(obj).reduce(
        (acc, [key, value]) => {
            const alteredEntry = toEntry(key as TKey, value as TValue)
            if (alteredEntry) acc[alteredEntry[0]] = alteredEntry[1]
            return acc
        },
        {} as Record<TNewKey, TNewValue>
    )
}

The example could become

const ra = {
    name: 'Ra',
    power: 'sun',
    rank: 100,
    culture: 'egypt'
}

mapEntries(ra, (key, value) =>  (key !== 'power') ? [key.toUpperCase(), `${value}`] : undefined)
// returns { "NAME": "Ra", "RANK": "100", "CULTURE": "egypt" }
@stefaanv
Copy link
Author

Pull request 367 created to resolv this issue

@aleclarson
Copy link

aleclarson commented Jun 28, 2024

So this is kind of like combining select with Object.entries and Object.fromEntries (and yours is obviously more performant).

Object.fromEntries(
  select(
    Object.entries(object),
    ([key]) => key !== 'power',
    ([key, value]) => [key.toUpperCase(), `${value}`],
  ),
)

Should it be a new function called selectEntries?

I'd be open to a PR in Radashi.

edit: Over at Radashi, we came to the conclusion that this feature request doesn't meet the project standards. See here for more context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants