Skip to content

Commit

Permalink
refactor(eio): bump cookie to version 1.0.2
Browse files Browse the repository at this point in the history
Release notes: https://github.com/jshttp/cookie/releases/tag/v1.0.0

The types are now included in the npm package. The `CookieSerializeOptions` type, which is used in our `ServerOptions` type, has been renamed to `SerializeOptions`, but there are no breaking change.

Related: #5231
  • Loading branch information
darrachequesne committed Nov 21, 2024
1 parent 91e1c8b commit 7427109
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 18 deletions.
22 changes: 8 additions & 14 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/engine.io/lib/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ import { EventEmitter } from "events";
import { Socket } from "./socket";
import debugModule from "debug";
import { serialize } from "cookie";
import type { SerializeOptions } from "cookie";
import { Server as DEFAULT_WS_ENGINE } from "ws";
import type {
IncomingMessage,
Server as HttpServer,
ServerResponse,
} from "http";
import type { CookieSerializeOptions } from "cookie";
import type { CorsOptions, CorsOptionsDelegate } from "cors";
import type { Duplex } from "stream";
import { WebTransport } from "./transports/webtransport";
Expand Down Expand Up @@ -123,7 +123,7 @@ export interface ServerOptions {
* might be used for sticky-session. Defaults to not sending any cookie.
* @default false
*/
cookie?: (CookieSerializeOptions & { name: string }) | boolean;
cookie?: (SerializeOptions & { name: string }) | boolean;
/**
* the options that will be forwarded to the cors module
*/
Expand Down
3 changes: 1 addition & 2 deletions packages/engine.io/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,11 @@
],
"license": "MIT",
"dependencies": {
"@types/cookie": "^0.4.1",
"@types/cors": "^2.8.12",
"@types/node": ">=10.0.0",
"accepts": "~1.3.4",
"base64id": "2.0.0",
"cookie": "~0.7.2",
"cookie": "~1.0.2",
"cors": "~2.8.5",
"debug": "~4.3.1",
"engine.io-parser": "~5.2.1",
Expand Down

0 comments on commit 7427109

Please sign in to comment.