Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Spring Reactive #23

Open
dineshvenkat opened this issue Jul 13, 2020 · 7 comments
Open

Support for Spring Reactive #23

dineshvenkat opened this issue Jul 13, 2020 · 7 comments

Comments

@dineshvenkat
Copy link

Is it possible to integrate this library with Spring reactive framework which is no longer supporting HttpServletRequests?
Not able to use the Spring example here https://socketio.github.io/engine.io-server-java/spring-integration.html to integrate the library with Spring Webflux.

@trinopoty
Copy link
Collaborator

I'll need to explore this more. I'll get back to you.

@dineshvenkat
Copy link
Author

Hi, Did you get a chance to look at this? We are already using Spring Webflux extensively and it will be great for us to integrate and use this library if it has support for Spring Webflux.

@trinopoty
Copy link
Collaborator

It seems like Spring Webflux indeed does not provide a way to get HttpServletRequest. Currently, the only way to use engine.io/socket.io with Spring Webflux is to add a servlet above Spring's DispatcherServlet.
Hopefully, I will figure out how to make engine.io work with Spring Webflux soon.

@dineshvenkat
Copy link
Author

Great to know you are planning to figure this out. Will this be planned against any Java Engine.io release? Wondering whether this is some minor enhancement we can wait for few days or look for other options.

@trinopoty
Copy link
Collaborator

While I do hope to be able to get to this soon. If your need is urgent, I suggest trying out other solutions in the meantime.

@trinopoty
Copy link
Collaborator

It seems like it's possible to use Spring MVC and Spring Webflux together in a single project. If possible, please try that approach out.

@trinopoty
Copy link
Collaborator

I've had a look at this and it'll require significant rework of the library to make it compatible with Webflux.
Needless to say, this will take some time. I'd advise trying out other methods in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants