Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is EngineIoServer / EngineIoSocket thread-safe? #19

Closed
plaa opened this issue Dec 13, 2019 · 3 comments
Closed

Is EngineIoServer / EngineIoSocket thread-safe? #19

plaa opened this issue Dec 13, 2019 · 3 comments

Comments

@plaa
Copy link

plaa commented Dec 13, 2019

The documentation (site / JavaDoc) does not state anywhere whether EngineIoServer or EngineIoSocket is thread-safe? Can for example socket.send be called from any thread, or does it need to be synchronized by the user?

@trinopoty
Copy link
Collaborator

socket.send is indeed thread safe and does not need any synchronization on part of the user.
Anything that's not thread safe is an implementation issue.

@plaa
Copy link
Author

plaa commented Dec 14, 2019

It would be good to add this to the docs (preferably both on the general site and on each class in the Javadoc). If nothing is mentioned, the only safe thing is to assume classes are not thread-safe.

@trinopoty
Copy link
Collaborator

I'll update the document sometime soon.
You can also submit a PR for it if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants