From bafe0f4beac593e6356a82c29f29dbc4d9fc54b8 Mon Sep 17 00:00:00 2001 From: SeungHun Choe <13363349+uOOOO@users.noreply.github.com> Date: Mon, 9 Dec 2019 15:45:24 +0900 Subject: [PATCH] Fix findbugs report --- .../java/com/hannesdorfmann/mosby3/ActivityMviDelegateImpl.java | 2 +- .../java/com/hannesdorfmann/mosby3/FragmentMviDelegateImpl.java | 2 +- .../com/hannesdorfmann/mosby3/ViewGroupMviDelegateImpl.java | 2 +- .../mosby3/mvp/delegate/ActivityMvpDelegateImpl.java | 2 +- .../mosby3/mvp/delegate/FragmentMvpDelegateImpl.java | 2 +- .../mosby3/mvp/delegate/ViewGroupMvpDelegateImpl.java | 2 +- .../main/java/com/hannesdorfmann/mosby3/PresenterManager.java | 2 +- .../mosby3/mvp/delegate/ActivityMvpViewStateDelegateImpl.java | 2 +- .../mosby3/mvp/delegate/FragmentMvpViewStateDelegateImpl.java | 2 +- .../mosby3/mvp/delegate/ViewGroupMvpViewStateDelegateImpl.java | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/mvi/src/main/java/com/hannesdorfmann/mosby3/ActivityMviDelegateImpl.java b/mvi/src/main/java/com/hannesdorfmann/mosby3/ActivityMviDelegateImpl.java index 8c8d0a2b..747bb8e7 100644 --- a/mvi/src/main/java/com/hannesdorfmann/mosby3/ActivityMviDelegateImpl.java +++ b/mvi/src/main/java/com/hannesdorfmann/mosby3/ActivityMviDelegateImpl.java @@ -42,7 +42,7 @@ public class ActivityMviDelegateImpl> implements FragmentMviDelegate { - public static boolean DEBUG = false; + public static final boolean DEBUG = false; private static final String DEBUG_TAG = "FragmentMviDelegateImpl"; private static final String KEY_MOSBY_VIEW_ID = "com.hannesdorfmann.mosby3.fragment.mvi.id"; diff --git a/mvi/src/main/java/com/hannesdorfmann/mosby3/ViewGroupMviDelegateImpl.java b/mvi/src/main/java/com/hannesdorfmann/mosby3/ViewGroupMviDelegateImpl.java index 12e23b4e..cc43fc11 100644 --- a/mvi/src/main/java/com/hannesdorfmann/mosby3/ViewGroupMviDelegateImpl.java +++ b/mvi/src/main/java/com/hannesdorfmann/mosby3/ViewGroupMviDelegateImpl.java @@ -41,7 +41,7 @@ public class ViewGroupMviDelegateImpl delegateCallback; diff --git a/mvp/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/ActivityMvpDelegateImpl.java b/mvp/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/ActivityMvpDelegateImpl.java index 35df6bcb..ee84ede6 100644 --- a/mvp/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/ActivityMvpDelegateImpl.java +++ b/mvp/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/ActivityMvpDelegateImpl.java @@ -39,7 +39,7 @@ public class ActivityMvpDelegateImpl delegateCallback; diff --git a/mvp/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/FragmentMvpDelegateImpl.java b/mvp/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/FragmentMvpDelegateImpl.java index f6b46d89..fe7ef233 100644 --- a/mvp/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/FragmentMvpDelegateImpl.java +++ b/mvp/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/FragmentMvpDelegateImpl.java @@ -47,7 +47,7 @@ public class FragmentMvpDelegateImpl delegateCallback; diff --git a/mvp/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/ViewGroupMvpDelegateImpl.java b/mvp/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/ViewGroupMvpDelegateImpl.java index 20ca480b..ac04a853 100644 --- a/mvp/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/ViewGroupMvpDelegateImpl.java +++ b/mvp/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/ViewGroupMvpDelegateImpl.java @@ -52,7 +52,7 @@ public class ViewGroupMvpDelegateImpl delegateCallback; diff --git a/presentermanager/src/main/java/com/hannesdorfmann/mosby3/PresenterManager.java b/presentermanager/src/main/java/com/hannesdorfmann/mosby3/PresenterManager.java index c22e5b04..02478f9e 100644 --- a/presentermanager/src/main/java/com/hannesdorfmann/mosby3/PresenterManager.java +++ b/presentermanager/src/main/java/com/hannesdorfmann/mosby3/PresenterManager.java @@ -33,7 +33,7 @@ */ final public class PresenterManager { - public static boolean DEBUG = false; + public static final boolean DEBUG = false; public static final String DEBUG_TAG = "PresenterManager"; final static String KEY_ACTIVITY_ID = "com.hannesdorfmann.mosby3.MosbyPresenterManagerActivityId"; diff --git a/viewstate/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/ActivityMvpViewStateDelegateImpl.java b/viewstate/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/ActivityMvpViewStateDelegateImpl.java index bc487fa2..170f2139 100644 --- a/viewstate/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/ActivityMvpViewStateDelegateImpl.java +++ b/viewstate/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/ActivityMvpViewStateDelegateImpl.java @@ -35,7 +35,7 @@ public class ActivityMvpViewStateDelegateImpl, VS extends ViewState> extends ActivityMvpDelegateImpl { - public static boolean DEBUG = false; + public static final boolean DEBUG = false; private static final String DEBUG_TAG = "ActivityMvpViewStateDel"; private MvpViewStateDelegateCallback delegateCallback; diff --git a/viewstate/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/FragmentMvpViewStateDelegateImpl.java b/viewstate/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/FragmentMvpViewStateDelegateImpl.java index 19708b21..04d5013f 100644 --- a/viewstate/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/FragmentMvpViewStateDelegateImpl.java +++ b/viewstate/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/FragmentMvpViewStateDelegateImpl.java @@ -58,7 +58,7 @@ public class FragmentMvpViewStateDelegateImpl delegateCallback; private boolean applyViewState = false; diff --git a/viewstate/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/ViewGroupMvpViewStateDelegateImpl.java b/viewstate/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/ViewGroupMvpViewStateDelegateImpl.java index ce20f963..c908ed81 100644 --- a/viewstate/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/ViewGroupMvpViewStateDelegateImpl.java +++ b/viewstate/src/main/java/com/hannesdorfmann/mosby3/mvp/delegate/ViewGroupMvpViewStateDelegateImpl.java @@ -41,7 +41,7 @@ public class ViewGroupMvpViewStateDelegateImpl delegateCallback; private String mosbyViewId;