Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute rule on the aggregator ('pom' packaging) #64

Open
1 of 3 tasks
skylartd opened this issue Nov 27, 2023 · 1 comment
Open
1 of 3 tasks

Execute rule on the aggregator ('pom' packaging) #64

skylartd opened this issue Nov 27, 2023 · 1 comment

Comments

@skylartd
Copy link

Summary

There is archunit test(Layering testing) that need to perform on 'pom' packaging but the default behavior of the plugin is skip 'pom' packaging by default.

Type of Issue

It is a :

  • bug
  • request
  • question regarding the documentation

Motivation

I want to perform Archunit Layer Check using the plugin on many of our projects.

Current Behavior

The plugin will skip 'pom' packaging by default

Expected Behavior

The plugin configuration should provide a way to execute archunit check on 'pom' packaging and all its sub-module projects instead of just skipping it.
For example we can provide a configuration in the applyOn like this.

<configurableRule>
    <rule>com.test.LayerTest</rule>
    <applyOn>
        <!-- can be "true" or "false" -->
        <aggregator>true</aggregator>
    </applyOn>

    <checks>
        <check>LAYER_CHECK</check>
    </checks>
</configurableRule>
@skylartd
Copy link
Author

I've created 2 PRs (1 in core and 1 in the plugin), can you guys help me to take a look?
societe-generale/arch-unit-build-plugin-core#83
#65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant