Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd_is_installed fails if no utils defined #44

Open
1 task
snystrom opened this issue Oct 26, 2020 · 1 comment
Open
1 task

cmd_is_installed fails if no utils defined #44

snystrom opened this issue Oct 26, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@snystrom
Copy link
Owner

snystrom commented Oct 26, 2020

Because cmd_is_installed calls util = TRUE, if no utils, get error. This really highlights how this is a bad design choice to begin with #22.

my_fun <- cmd_search_path("~/my/path")
is_installed <- cmd_is_installed(my_fun)
is_installed()

Error in util == TRUE : 
  comparison (1) is possible only for atomic and list types

Tests to add

  • path search w/ no utils -> is_installed()
@snystrom snystrom added the bug Something isn't working label Oct 26, 2020
@snystrom snystrom self-assigned this Oct 26, 2020
@snystrom
Copy link
Owner Author

Hotfix could be if util == TRUE -> return everything even if no utils?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant