diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index bd0c6e9..ab2112d 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1 +1 @@ -* @snyk/road-runner +* @snyk/hammerhead diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 265db3c..f162e53 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -8,7 +8,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Fetch sources - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Validate Gradle Wrapper uses: gradle/wrapper-validation-action@v1 @@ -19,15 +19,16 @@ jobs: runs-on: ubuntu-latest steps: - name: Fetch sources - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Setup Java - uses: actions/setup-java@v1 + uses: actions/setup-java@v3 with: - java-version: 11 + java-version: 17 + distribution: 'zulu' - name: Setup Gradle cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: | ~/.gradle/caches diff --git a/CHANGELOG.md b/CHANGELOG.md index 41a7eed..b8a7110 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +## [2.3.5] - 2023-01 +- refactor: allow injection of retrofit client in API implementation +- refactor: remove setBaseURL API method - inject/use your configured retrofit client instead in the API implementaiton. + ## [2.3.4] - 2022-05 - update fallbacks for supported extensions and configFiles - change: provide ability to distinguish if supported file belong to supported extensions or configFiles diff --git a/build.gradle b/build.gradle index 706558c..5339799 100644 --- a/build.gradle +++ b/build.gradle @@ -6,7 +6,7 @@ plugins { group = "io.snyk.code.sdk" archivesBaseName = "snyk-code-client" -version = "2.3.4" +version = "2.3.5" repositories { mavenLocal() @@ -48,7 +48,7 @@ dependencies { implementation 'com.squareup.retrofit2:retrofit:2.9.0' implementation 'com.squareup.retrofit2:converter-gson:2.9.0' implementation 'org.jetbrains:annotations:22.0.0' - implementation 'com.squareup.okhttp3:logging-interceptor:4.9.2' + implementation 'com.squareup.okhttp3:logging-interceptor:4.10.0' testImplementation 'junit:junit:4.13.2' integTestImplementation 'junit:junit:4.13.2' diff --git a/gradle/wrapper/gradle-wrapper.jar b/gradle/wrapper/gradle-wrapper.jar index f3d88b1..943f0cb 100644 Binary files a/gradle/wrapper/gradle-wrapper.jar and b/gradle/wrapper/gradle-wrapper.jar differ diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index c896a87..f398c33 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -1,6 +1,6 @@ -#Fri Mar 13 19:35:05 MSK 2020 -distributionUrl=https\://services.gradle.org/distributions/gradle-6.2.2-all.zip distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists -zipStorePath=wrapper/dists +distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip +networkTimeout=10000 zipStoreBase=GRADLE_USER_HOME +zipStorePath=wrapper/dists diff --git a/gradlew b/gradlew index 2fe81a7..65dcd68 100755 --- a/gradlew +++ b/gradlew @@ -1,7 +1,7 @@ -#!/usr/bin/env sh +#!/bin/sh # -# Copyright 2015 the original author or authors. +# Copyright © 2015-2021 the original authors. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -17,78 +17,113 @@ # ############################################################################## -## -## Gradle start up script for UN*X -## +# +# Gradle start up script for POSIX generated by Gradle. +# +# Important for running: +# +# (1) You need a POSIX-compliant shell to run this script. If your /bin/sh is +# noncompliant, but you have some other compliant shell such as ksh or +# bash, then to run this script, type that shell name before the whole +# command line, like: +# +# ksh Gradle +# +# Busybox and similar reduced shells will NOT work, because this script +# requires all of these POSIX shell features: +# * functions; +# * expansions «$var», «${var}», «${var:-default}», «${var+SET}», +# «${var#prefix}», «${var%suffix}», and «$( cmd )»; +# * compound commands having a testable exit status, especially «case»; +# * various built-in commands including «command», «set», and «ulimit». +# +# Important for patching: +# +# (2) This script targets any POSIX shell, so it avoids extensions provided +# by Bash, Ksh, etc; in particular arrays are avoided. +# +# The "traditional" practice of packing multiple parameters into a +# space-separated string is a well documented source of bugs and security +# problems, so this is (mostly) avoided, by progressively accumulating +# options in "$@", and eventually passing that to Java. +# +# Where the inherited environment variables (DEFAULT_JVM_OPTS, JAVA_OPTS, +# and GRADLE_OPTS) rely on word-splitting, this is performed explicitly; +# see the in-line comments for details. +# +# There are tweaks for specific operating systems such as AIX, CygWin, +# Darwin, MinGW, and NonStop. +# +# (3) This script is generated from the Groovy template +# https://github.com/gradle/gradle/blob/HEAD/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt +# within the Gradle project. +# +# You can find Gradle at https://github.com/gradle/gradle/. +# ############################################################################## # Attempt to set APP_HOME + # Resolve links: $0 may be a link -PRG="$0" -# Need this for relative symlinks. -while [ -h "$PRG" ] ; do - ls=`ls -ld "$PRG"` - link=`expr "$ls" : '.*-> \(.*\)$'` - if expr "$link" : '/.*' > /dev/null; then - PRG="$link" - else - PRG=`dirname "$PRG"`"/$link" - fi +app_path=$0 + +# Need this for daisy-chained symlinks. +while + APP_HOME=${app_path%"${app_path##*/}"} # leaves a trailing /; empty if no leading path + [ -h "$app_path" ] +do + ls=$( ls -ld "$app_path" ) + link=${ls#*' -> '} + case $link in #( + /*) app_path=$link ;; #( + *) app_path=$APP_HOME$link ;; + esac done -SAVED="`pwd`" -cd "`dirname \"$PRG\"`/" >/dev/null -APP_HOME="`pwd -P`" -cd "$SAVED" >/dev/null -APP_NAME="Gradle" -APP_BASE_NAME=`basename "$0"` +# This is normally unused +# shellcheck disable=SC2034 +APP_BASE_NAME=${0##*/} +APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' # Use the maximum available, or set MAX_FD != -1 to use that value. -MAX_FD="maximum" +MAX_FD=maximum warn () { echo "$*" -} +} >&2 die () { echo echo "$*" echo exit 1 -} +} >&2 # OS specific support (must be 'true' or 'false'). cygwin=false msys=false darwin=false nonstop=false -case "`uname`" in - CYGWIN* ) - cygwin=true - ;; - Darwin* ) - darwin=true - ;; - MINGW* ) - msys=true - ;; - NONSTOP* ) - nonstop=true - ;; +case "$( uname )" in #( + CYGWIN* ) cygwin=true ;; #( + Darwin* ) darwin=true ;; #( + MSYS* | MINGW* ) msys=true ;; #( + NONSTOP* ) nonstop=true ;; esac CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar + # Determine the Java command to use to start the JVM. if [ -n "$JAVA_HOME" ] ; then if [ -x "$JAVA_HOME/jre/sh/java" ] ; then # IBM's JDK on AIX uses strange locations for the executables - JAVACMD="$JAVA_HOME/jre/sh/java" + JAVACMD=$JAVA_HOME/jre/sh/java else - JAVACMD="$JAVA_HOME/bin/java" + JAVACMD=$JAVA_HOME/bin/java fi if [ ! -x "$JAVACMD" ] ; then die "ERROR: JAVA_HOME is set to an invalid directory: $JAVA_HOME @@ -97,7 +132,7 @@ Please set the JAVA_HOME variable in your environment to match the location of your Java installation." fi else - JAVACMD="java" + JAVACMD=java which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. Please set the JAVA_HOME variable in your environment to match the @@ -105,79 +140,105 @@ location of your Java installation." fi # Increase the maximum file descriptors if we can. -if [ "$cygwin" = "false" -a "$darwin" = "false" -a "$nonstop" = "false" ] ; then - MAX_FD_LIMIT=`ulimit -H -n` - if [ $? -eq 0 ] ; then - if [ "$MAX_FD" = "maximum" -o "$MAX_FD" = "max" ] ; then - MAX_FD="$MAX_FD_LIMIT" - fi - ulimit -n $MAX_FD - if [ $? -ne 0 ] ; then - warn "Could not set maximum file descriptor limit: $MAX_FD" - fi - else - warn "Could not query maximum file descriptor limit: $MAX_FD_LIMIT" - fi +if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then + case $MAX_FD in #( + max*) + # In POSIX sh, ulimit -H is undefined. That's why the result is checked to see if it worked. + # shellcheck disable=SC3045 + MAX_FD=$( ulimit -H -n ) || + warn "Could not query maximum file descriptor limit" + esac + case $MAX_FD in #( + '' | soft) :;; #( + *) + # In POSIX sh, ulimit -n is undefined. That's why the result is checked to see if it worked. + # shellcheck disable=SC3045 + ulimit -n "$MAX_FD" || + warn "Could not set maximum file descriptor limit to $MAX_FD" + esac fi -# For Darwin, add options to specify how the application appears in the dock -if $darwin; then - GRADLE_OPTS="$GRADLE_OPTS \"-Xdock:name=$APP_NAME\" \"-Xdock:icon=$APP_HOME/media/gradle.icns\"" -fi +# Collect all arguments for the java command, stacking in reverse order: +# * args from the command line +# * the main class name +# * -classpath +# * -D...appname settings +# * --module-path (only if needed) +# * DEFAULT_JVM_OPTS, JAVA_OPTS, and GRADLE_OPTS environment variables. # For Cygwin or MSYS, switch paths to Windows format before running java -if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then - APP_HOME=`cygpath --path --mixed "$APP_HOME"` - CLASSPATH=`cygpath --path --mixed "$CLASSPATH"` - JAVACMD=`cygpath --unix "$JAVACMD"` - - # We build the pattern for arguments to be converted via cygpath - ROOTDIRSRAW=`find -L / -maxdepth 1 -mindepth 1 -type d 2>/dev/null` - SEP="" - for dir in $ROOTDIRSRAW ; do - ROOTDIRS="$ROOTDIRS$SEP$dir" - SEP="|" - done - OURCYGPATTERN="(^($ROOTDIRS))" - # Add a user-defined pattern to the cygpath arguments - if [ "$GRADLE_CYGPATTERN" != "" ] ; then - OURCYGPATTERN="$OURCYGPATTERN|($GRADLE_CYGPATTERN)" - fi +if "$cygwin" || "$msys" ; then + APP_HOME=$( cygpath --path --mixed "$APP_HOME" ) + CLASSPATH=$( cygpath --path --mixed "$CLASSPATH" ) + + JAVACMD=$( cygpath --unix "$JAVACMD" ) + # Now convert the arguments - kludge to limit ourselves to /bin/sh - i=0 - for arg in "$@" ; do - CHECK=`echo "$arg"|egrep -c "$OURCYGPATTERN" -` - CHECK2=`echo "$arg"|egrep -c "^-"` ### Determine if an option - - if [ $CHECK -ne 0 ] && [ $CHECK2 -eq 0 ] ; then ### Added a condition - eval `echo args$i`=`cygpath --path --ignore --mixed "$arg"` - else - eval `echo args$i`="\"$arg\"" + for arg do + if + case $arg in #( + -*) false ;; # don't mess with options #( + /?*) t=${arg#/} t=/${t%%/*} # looks like a POSIX filepath + [ -e "$t" ] ;; #( + *) false ;; + esac + then + arg=$( cygpath --path --ignore --mixed "$arg" ) fi - i=`expr $i + 1` + # Roll the args list around exactly as many times as the number of + # args, so each arg winds up back in the position where it started, but + # possibly modified. + # + # NB: a `for` loop captures its iteration list before it begins, so + # changing the positional parameters here affects neither the number of + # iterations, nor the values presented in `arg`. + shift # remove old arg + set -- "$@" "$arg" # push replacement arg done - case $i in - 0) set -- ;; - 1) set -- "$args0" ;; - 2) set -- "$args0" "$args1" ;; - 3) set -- "$args0" "$args1" "$args2" ;; - 4) set -- "$args0" "$args1" "$args2" "$args3" ;; - 5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;; - 6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;; - 7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;; - 8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;; - 9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;; - esac fi -# Escape application args -save () { - for i do printf %s\\n "$i" | sed "s/'/'\\\\''/g;1s/^/'/;\$s/\$/' \\\\/" ; done - echo " " -} -APP_ARGS=`save "$@"` +# Collect all arguments for the java command; +# * $DEFAULT_JVM_OPTS, $JAVA_OPTS, and $GRADLE_OPTS can contain fragments of +# shell script including quotes and variable substitutions, so put them in +# double quotes to make sure that they get re-expanded; and +# * put everything else in single quotes, so that it's not re-expanded. + +set -- \ + "-Dorg.gradle.appname=$APP_BASE_NAME" \ + -classpath "$CLASSPATH" \ + org.gradle.wrapper.GradleWrapperMain \ + "$@" + +# Stop when "xargs" is not available. +if ! command -v xargs >/dev/null 2>&1 +then + die "xargs is not available" +fi + +# Use "xargs" to parse quoted args. +# +# With -n1 it outputs one arg per line, with the quotes and backslashes removed. +# +# In Bash we could simply go: +# +# readarray ARGS < <( xargs -n1 <<<"$var" ) && +# set -- "${ARGS[@]}" "$@" +# +# but POSIX shell has neither arrays nor command substitution, so instead we +# post-process each arg (as a line of input to sed) to backslash-escape any +# character that might be a shell metacharacter, then use eval to reverse +# that process (while maintaining the separation between arguments), and wrap +# the whole thing up as a single "set" statement. +# +# This will of course break if any of these variables contains a newline or +# an unmatched quote. +# -# Collect all arguments for the java command, following the shell quoting and substitution rules -eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS" +eval "set -- $( + printf '%s\n' "$DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS" | + xargs -n1 | + sed ' s~[^-[:alnum:]+,./:=@_]~\\&~g; ' | + tr '\n' ' ' + )" '"$@"' exec "$JAVACMD" "$@" diff --git a/gradlew.bat b/gradlew.bat index 62bd9b9..93e3f59 100755 --- a/gradlew.bat +++ b/gradlew.bat @@ -14,7 +14,7 @@ @rem limitations under the License. @rem -@if "%DEBUG%" == "" @echo off +@if "%DEBUG%"=="" @echo off @rem ########################################################################## @rem @rem Gradle startup script for Windows @@ -25,7 +25,8 @@ if "%OS%"=="Windows_NT" setlocal set DIRNAME=%~dp0 -if "%DIRNAME%" == "" set DIRNAME=. +if "%DIRNAME%"=="" set DIRNAME=. +@rem This is normally unused set APP_BASE_NAME=%~n0 set APP_HOME=%DIRNAME% @@ -40,7 +41,7 @@ if defined JAVA_HOME goto findJavaFromJavaHome set JAVA_EXE=java.exe %JAVA_EXE% -version >NUL 2>&1 -if "%ERRORLEVEL%" == "0" goto init +if %ERRORLEVEL% equ 0 goto execute echo. echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. @@ -54,7 +55,7 @@ goto fail set JAVA_HOME=%JAVA_HOME:"=% set JAVA_EXE=%JAVA_HOME%/bin/java.exe -if exist "%JAVA_EXE%" goto init +if exist "%JAVA_EXE%" goto execute echo. echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME% @@ -64,38 +65,26 @@ echo location of your Java installation. goto fail -:init -@rem Get command-line arguments, handling Windows variants - -if not "%OS%" == "Windows_NT" goto win9xME_args - -:win9xME_args -@rem Slurp the command line arguments. -set CMD_LINE_ARGS= -set _SKIP=2 - -:win9xME_args_slurp -if "x%~1" == "x" goto execute - -set CMD_LINE_ARGS=%* - :execute @rem Setup the command line set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar + @rem Execute Gradle -"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %CMD_LINE_ARGS% +"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %* :end @rem End local scope for the variables with windows NT shell -if "%ERRORLEVEL%"=="0" goto mainEnd +if %ERRORLEVEL% equ 0 goto mainEnd :fail rem Set variable GRADLE_EXIT_CONSOLE if you need the _script_ return code instead of rem the _cmd.exe /c_ return code! -if not "" == "%GRADLE_EXIT_CONSOLE%" exit 1 -exit /b 1 +set EXIT_CODE=%ERRORLEVEL% +if %EXIT_CODE% equ 0 set EXIT_CODE=1 +if not ""=="%GRADLE_EXIT_CONSOLE%" exit %EXIT_CODE% +exit /b %EXIT_CODE% :mainEnd if "%OS%"=="Windows_NT" endlocal diff --git a/src/integTest/java/ai/deepcode/javaclient/DeepCodeRestApiImplTest.java b/src/integTest/java/ai/deepcode/javaclient/DeepCodeRestApiImplTest.java index 2cb4874..e4b3dfd 100644 --- a/src/integTest/java/ai/deepcode/javaclient/DeepCodeRestApiImplTest.java +++ b/src/integTest/java/ai/deepcode/javaclient/DeepCodeRestApiImplTest.java @@ -57,29 +57,6 @@ public class DeepCodeRestApiImplTest { private static final DeepCodeRestApi restApiClient = new DeepCodeRestApiImpl(); - @Test - public void _022_setBaseUrl() { - System.out.println("\n--------------Set base URL----------------\n"); - try { - doSetBaseUrlTest("", 401); - doSetBaseUrlTest("https://www.google.com/", 404); - doSetBaseUrlTest("https://deeproxy.snyk.io/", 401); - } finally { - restApiClient.setBaseUrl("", false, false); - } - } - - private void doSetBaseUrlTest(String baseUrl, int expectedStatusCode) { - restApiClient.setBaseUrl(baseUrl, false, true); - EmptyResponse response = restApiClient.checkBundle("blabla", "irrelevant"); - int status = response.getStatusCode(); - String description = response.getStatusDescription(); - System.out.printf( - "Check Session call to [%3$s] with token [%1$s] return [%2$d] code: [%4$s]\n", - "blabla", status, baseUrl, description); - assertEquals(expectedStatusCode, status); - } - @Test public void _025_getFilters() { System.out.println("\n--------------Get Filters----------------\n"); @@ -101,7 +78,6 @@ public void _025_getFilters() { @Test public void _030_createBundle_from_source() throws NoSuchAlgorithmException { System.out.println("\n--------------Create Bundle from Source----------------\n"); - restApiClient.setBaseUrl(baseUrl, false, true); CreateBundleResponse response = createBundleFromSource(loggedToken); assertNotNull(response); System.out.printf( @@ -219,7 +195,6 @@ public void _036_Check_Bundle() { } private FileHashRequest createFileHashRequest(String fakeFileName) { - restApiClient.setBaseUrl(baseUrl, false, true); final File testFile = new File(getClass().getClassLoader().getResource("AnnotatorTest.java").getFile()); String absolutePath = testFile.getAbsolutePath(); diff --git a/src/main/java/ai/deepcode/javaclient/DeepCodeRestApi.java b/src/main/java/ai/deepcode/javaclient/DeepCodeRestApi.java index 584b448..6490c8a 100644 --- a/src/main/java/ai/deepcode/javaclient/DeepCodeRestApi.java +++ b/src/main/java/ai/deepcode/javaclient/DeepCodeRestApi.java @@ -6,20 +6,10 @@ import ai.deepcode.javaclient.responses.GetAnalysisResponse; import ai.deepcode.javaclient.responses.GetFiltersResponse; import org.jetbrains.annotations.NotNull; -import org.jetbrains.annotations.Nullable; import java.util.List; public interface DeepCodeRestApi { - /** - * Re-set baseUrl for retrofit instance - * - * @param baseUrl new baseUrl. Null or empty "" value will reset to default {@code - * #API_URL} - */ - void setBaseUrl( - @Nullable String baseUrl, boolean disableSslVerification, boolean requestLogging); - /** * Creates a new bundle with direct file(s) source. * diff --git a/src/main/java/ai/deepcode/javaclient/DeepCodeRestApiImpl.java b/src/main/java/ai/deepcode/javaclient/DeepCodeRestApiImpl.java index 1a71855..b45e9ac 100644 --- a/src/main/java/ai/deepcode/javaclient/DeepCodeRestApiImpl.java +++ b/src/main/java/ai/deepcode/javaclient/DeepCodeRestApiImpl.java @@ -12,7 +12,6 @@ import okhttp3.OkHttpClient; import okhttp3.logging.HttpLoggingInterceptor; import org.jetbrains.annotations.NotNull; -import org.jetbrains.annotations.Nullable; import retrofit2.Call; import retrofit2.Response; import retrofit2.Retrofit; @@ -46,6 +45,13 @@ public class DeepCodeRestApiImpl implements DeepCodeRestApi { private static Retrofit retrofit = buildRetrofit(API_URL, false, false); + public DeepCodeRestApiImpl(Retrofit retrofit) { + DeepCodeRestApiImpl.retrofit = retrofit; + } + + public DeepCodeRestApiImpl() { + } + // Create simple REST adapter which points the baseUrl. private static Retrofit buildRetrofit( String baseUrl, boolean disableSslVerification, boolean requestLogging) { @@ -108,22 +114,6 @@ public X509Certificate[] getAcceptedIssuers() { }; } - /** - * Re-set baseUrl for retrofit instance - * - * @param baseUrl new baseUrl. Null or empty "" value will reset to default {@code - * #API_URL} - */ - @Override - public void setBaseUrl( - @Nullable String baseUrl, boolean disableSslVerification, boolean requestLogging) { - retrofit = - buildRetrofit( - (baseUrl == null || baseUrl.isEmpty()) ? API_URL : baseUrl, - disableSslVerification, - requestLogging); - } - private interface CreateBundleCall { @retrofit2.http.Headers("Content-Type: application/json") @POST("bundle") diff --git a/src/main/java/ai/deepcode/javaclient/core/DeepCodeParamsBase.java b/src/main/java/ai/deepcode/javaclient/core/DeepCodeParamsBase.java index 3c129ac..9a00b78 100644 --- a/src/main/java/ai/deepcode/javaclient/core/DeepCodeParamsBase.java +++ b/src/main/java/ai/deepcode/javaclient/core/DeepCodeParamsBase.java @@ -9,8 +9,6 @@ public abstract class DeepCodeParamsBase { // Settings private boolean isEnable; - private String apiUrl; - private boolean disableSslVerification; private boolean useLinter; private int minSeverity; private String sessionToken; @@ -36,8 +34,6 @@ protected DeepCodeParamsBase( DeepCodeRestApi restApi ) { this.isEnable = isEnable; - this.apiUrl = apiUrl; - this.disableSslVerification = disableSslVerification; this.useLinter = useLinter; this.minSeverity = minSeverity; this.sessionToken = sessionToken; @@ -87,37 +83,6 @@ public void setMinSeverity(int minSeverity) { this.minSeverity = minSeverity; } - @NotNull - public String getApiUrl() { - return apiUrl; - } - - public void setApiUrl(@NotNull String apiUrl) { - setApiUrl(apiUrl, false); - } - - public void setApiUrl(@NotNull String apiUrl, boolean disableSslVerification) { - setApiUrl(apiUrl, disableSslVerification, false); - } - - public void setApiUrl( - @NotNull String apiUrl, boolean disableSslVerification, boolean requestLogging) { - if (apiUrl.isEmpty()) apiUrl = "https://deeproxy.snyk.io/"; - if (!apiUrl.endsWith("/")) apiUrl += "/"; - if (apiUrl.equals(this.apiUrl)) return; - this.apiUrl = apiUrl; - this.disableSslVerification = disableSslVerification; - restApi.setBaseUrl(apiUrl, disableSslVerification, requestLogging); - } - - public boolean isDisableSslVerification() { - return disableSslVerification; - } - - public void setDisableSslVerification(boolean disableSslVerification) { - this.disableSslVerification = disableSslVerification; - } - public boolean isEnable() { return isEnable; } diff --git a/src/test/java/ai/deepcode/javaclient/core/mocks/DeepCodeRestApiMock.java b/src/test/java/ai/deepcode/javaclient/core/mocks/DeepCodeRestApiMock.java index 6c17749..eed2194 100644 --- a/src/test/java/ai/deepcode/javaclient/core/mocks/DeepCodeRestApiMock.java +++ b/src/test/java/ai/deepcode/javaclient/core/mocks/DeepCodeRestApiMock.java @@ -12,9 +12,6 @@ import java.util.List; public class DeepCodeRestApiMock implements DeepCodeRestApi { - @Override - public void setBaseUrl(@Nullable String baseUrl, boolean disableSslVerification, boolean requestLogging) {} - @Override public @NotNull CreateBundleResponse createBundle(String token, FileContentRequest files) { throw new UnsupportedOperationException();