Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OAuth support in Databricks Loader #1358

Closed
wants to merge 0 commits into from
Closed

Add OAuth support in Databricks Loader #1358

wants to merge 0 commits into from

Conversation

pondzix
Copy link
Contributor

@pondzix pondzix commented Aug 21, 2024 •
edited
Loading

New config section for storage:

"storage" : {
...
    "oauth": {
      "clientId": "client-id"
      "clientSecret": ${OAUTH_CLIENT_SECRET}
    }
}

So that we can set clientId and clientSecret authentication properties. Old-style password field (relying on personal access tokens) is still supported.

istreeter
istreeter approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@istreeter istreeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neatly done.

...es/loader/src/main/scala/com/snowplowanalytics/snowplow/rdbloader/config/StorageTarget.scala Outdated
Comment on lines 146 to 147
props.put("AuthMech", 11)
props.put("Auth_Flow", 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm enjoying the inconsistency of AuthMech and Auth_Flow!

@pondzix pondzix force-pushed the databricks_loader_oauth branch 3 times, most recently from 310af5a to 13b8305 Compare August 21, 2024 11:39
@pondzix pondzix changed the base branch from master to develop August 22, 2024 13:50
@pondzix pondzix closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@istreeter istreeter istreeter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pondzix @istreeter