Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use semantic versions for referencing third-party images #22

Open
petermikitsh opened this issue Jun 15, 2019 · 0 comments
Open

Comments

@petermikitsh
Copy link
Member

Within snow's codebase, we reference the latest tag for the kaniko image [0].

e.g:

            "containers": [
              {
                "name": "kaniko",
                "image": "gcr.io/kaniko-project/executor:latest", <--- let's not do this
                "args": [
                  "--context=dir:///kaniko/build-context",
                  "--destination=${imageName}",
                  "--skip-tls-verify"
                ],

This poses a problem if Kaniko ever introduces any breaking changes. We should specify a particular version, and upgrade it as necessary / cut new releases of Snow so users can also begin using newer versions of Kaniko.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant