From ea7d23011ae879e59e99b400bc5cc643937f0d20 Mon Sep 17 00:00:00 2001 From: Yuyang Wang Date: Mon, 26 Aug 2024 17:00:28 -0700 Subject: [PATCH 1/4] doc and comment fix --- docs/source/snowpark/functions.rst | 1 + src/snowflake/snowpark/functions.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/source/snowpark/functions.rst b/docs/source/snowpark/functions.rst index 9a381e5046a..877b884e7b4 100644 --- a/docs/source/snowpark/functions.rst +++ b/docs/source/snowpark/functions.rst @@ -196,6 +196,7 @@ Functions length listagg lit + ln locate log lower diff --git a/src/snowflake/snowpark/functions.py b/src/snowflake/snowpark/functions.py index 58c2ab8518c..559d8565db0 100644 --- a/src/snowflake/snowpark/functions.py +++ b/src/snowflake/snowpark/functions.py @@ -5982,7 +5982,7 @@ def vector_inner_product(v1: ColumnOrName, v2: ColumnOrName) -> Column: def ln(c: ColumnOrLiteral) -> Column: - """Returns the natrual log product of given column expression + """Returns the natrual log of given column expression Example:: >>> from snowflake.snowpark.functions import ln >>> from math import e From 3efea1938b253778be537930ac43bafc2fe477c2 Mon Sep 17 00:00:00 2001 From: Yuyang Wang Date: Tue, 27 Aug 2024 09:25:41 -0700 Subject: [PATCH 2/4] update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1cf5845439c..70a49943d3c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ #### Improvements +- Added support for `ln` in `snowflake.snowpark.functions` - Added support for specifying the following to `DataFrameWriter.save_as_table`: - `enable_schema_evolution` - `data_retention_time` From e777dc84fd406ef5cf77e196d48a72cecf63cce6 Mon Sep 17 00:00:00 2001 From: Yuyang Wang Date: Tue, 27 Aug 2024 09:56:17 -0700 Subject: [PATCH 3/4] fix docstring --- src/snowflake/snowpark/functions.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/snowflake/snowpark/functions.py b/src/snowflake/snowpark/functions.py index 559d8565db0..0375b93c3c6 100644 --- a/src/snowflake/snowpark/functions.py +++ b/src/snowflake/snowpark/functions.py @@ -5982,7 +5982,8 @@ def vector_inner_product(v1: ColumnOrName, v2: ColumnOrName) -> Column: def ln(c: ColumnOrLiteral) -> Column: - """Returns the natrual log of given column expression + """Returns the natrual log of given column expression. + Example:: >>> from snowflake.snowpark.functions import ln >>> from math import e From 1de64fcd0083c3e5dfd86893fc602ccc0c5b0cec Mon Sep 17 00:00:00 2001 From: Yuyang Wang Date: Wed, 28 Aug 2024 09:41:38 -0700 Subject: [PATCH 4/4] change docstring --- src/snowflake/snowpark/functions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/snowflake/snowpark/functions.py b/src/snowflake/snowpark/functions.py index 0375b93c3c6..89b2d3aa336 100644 --- a/src/snowflake/snowpark/functions.py +++ b/src/snowflake/snowpark/functions.py @@ -5982,7 +5982,7 @@ def vector_inner_product(v1: ColumnOrName, v2: ColumnOrName) -> Column: def ln(c: ColumnOrLiteral) -> Column: - """Returns the natrual log of given column expression. + """Returns the natrual logarithm of given column expression. Example:: >>> from snowflake.snowpark.functions import ln