From 1d5ba695dea13439e0c8f54f89867883000354d8 Mon Sep 17 00:00:00 2001 From: Naren Krishna Date: Fri, 26 Apr 2024 12:29:11 -0700 Subject: [PATCH 1/3] Remove large data values from test_unique.py to resolve flakes Signed-off-by: Naren Krishna --- tests/integ/modin/series/test_unique.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/integ/modin/series/test_unique.py b/tests/integ/modin/series/test_unique.py index 7c909b3ad0d..57838feef7f 100644 --- a/tests/integ/modin/series/test_unique.py +++ b/tests/integ/modin/series/test_unique.py @@ -26,7 +26,7 @@ def _make_nan_interleaved_float_series(): [12.0, 11.999999, 11.999999], ["A", "A", "C", "C", "A"], [None, "A", None, "B"], - native_pd.Series([1, 2, 2**63, 2**63], dtype=np.uint64), + native_pd.Series([1, 2, 2**10, 2**10], dtype=np.uint64), _make_nan_interleaved_float_series(), ] From 4727c52ae6a2e717461c3a7e3bc741e03359cd2b Mon Sep 17 00:00:00 2001 From: Naren Krishna Date: Mon, 29 Apr 2024 13:15:36 -0700 Subject: [PATCH 2/3] change to 2**34 Signed-off-by: Naren Krishna --- tests/integ/modin/series/test_unique.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/integ/modin/series/test_unique.py b/tests/integ/modin/series/test_unique.py index 57838feef7f..92ba9c46a49 100644 --- a/tests/integ/modin/series/test_unique.py +++ b/tests/integ/modin/series/test_unique.py @@ -26,7 +26,7 @@ def _make_nan_interleaved_float_series(): [12.0, 11.999999, 11.999999], ["A", "A", "C", "C", "A"], [None, "A", None, "B"], - native_pd.Series([1, 2, 2**10, 2**10], dtype=np.uint64), + native_pd.Series([1, 2, 2**34, 2**34], dtype=np.uint64), _make_nan_interleaved_float_series(), ] From c9d11f96ff1b672c1094fe9b989c90cda79fe9f6 Mon Sep 17 00:00:00 2001 From: Naren Krishna Date: Tue, 30 Apr 2024 10:17:30 -0700 Subject: [PATCH 3/3] Add xfails to test_unique to unblock daily CI run Signed-off-by: Naren Krishna --- tests/integ/modin/series/test_unique.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/integ/modin/series/test_unique.py b/tests/integ/modin/series/test_unique.py index 92ba9c46a49..ee42e0308ab 100644 --- a/tests/integ/modin/series/test_unique.py +++ b/tests/integ/modin/series/test_unique.py @@ -26,7 +26,12 @@ def _make_nan_interleaved_float_series(): [12.0, 11.999999, 11.999999], ["A", "A", "C", "C", "A"], [None, "A", None, "B"], - native_pd.Series([1, 2, 2**34, 2**34], dtype=np.uint64), + pytest.param( + native_pd.Series([1, 2, 2**63, 2**63], dtype=np.uint64), + marks=pytest.mark.xfail( + reason="SNOW-1356685: Dtype with unsigned int results in precision error" + ), + ), _make_nan_interleaved_float_series(), ]