Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Local Testing] Enable more tests #1052

Merged
merged 2 commits into from
Sep 25, 2023
Merged

[Local Testing] Enable more tests #1052

merged 2 commits into from
Sep 25, 2023

Conversation

sfc-gh-stan
Copy link
Collaborator

@sfc-gh-stan sfc-gh-stan commented Sep 18, 2023 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

  • Enables about 50 tests.

@sfc-gh-stan sfc-gh-stan force-pushed the local/enable-more-tests branch 2 times, most recently from 76d582a to 2854f9a Compare September 21, 2023 17:47
@sfc-gh-stan sfc-gh-stan marked this pull request as ready for review September 21, 2023 17:48
@sfc-gh-stan sfc-gh-stan requested a review from a team as a code owner September 21, 2023 17:48
@sfc-gh-stan sfc-gh-stan requested review from sfc-gh-aalam and sfc-gh-evandenberg and removed request for a team September 21, 2023 17:48
sfc-gh-aling
sfc-gh-aling approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@sfc-gh-aling sfc-gh-aling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-stan sfc-gh-stan merged commit b9946f3 into dev/local-testing Sep 25, 2023
8 of 39 checks passed
@sfc-gh-stan sfc-gh-stan deleted the local/enable-more-tests branch September 25, 2023 17:36
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-sfan sfc-gh-sfan sfc-gh-sfan approved these changes

@sfc-gh-aalam sfc-gh-aalam Awaiting requested review from sfc-gh-aalam sfc-gh-aalam is a code owner automatically assigned from snowflakedb/snowpark-python-api

@sfc-gh-evandenberg sfc-gh-evandenberg Awaiting requested review from sfc-gh-evandenberg sfc-gh-evandenberg is a code owner automatically assigned from snowflakedb/snowpark-python-api

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-stan @sfc-gh-sfan @sfc-gh-aling