Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query_generator for new compilation stage after optimization applied #2172

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

sfc-gh-yzou
Copy link
Collaborator

@sfc-gh-yzou sfc-gh-yzou commented Aug 27, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
    SNOW-1641324

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.
    The test Enable CTE Optimization merge gate is currently failing because

  1. the _projection_in_str for select statement is reset properly after updating, which causes the expr_alias is updated properly during query generation
  2. query parameter is not propogated properly during query generation which causes variable binding query fail

@sfc-gh-yzou sfc-gh-yzou added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Aug 27, 2024
@sfc-gh-yzou
Copy link
Collaborator Author

@sfc-gh-yzou sfc-gh-yzou marked this pull request as ready for review August 27, 2024 18:13
@sfc-gh-yzou sfc-gh-yzou requested a review from a team as a code owner August 27, 2024 18:13
@sfc-gh-yzou sfc-gh-yzou force-pushed the yzou-fix-cte-new-compilation branch from e13453d to 3edc501 Compare August 27, 2024 23:24
@sfc-gh-yzou sfc-gh-yzou merged commit a7c6820 into main Aug 28, 2024
32 of 34 checks passed
@sfc-gh-yzou sfc-gh-yzou deleted the yzou-fix-cte-new-compilation branch August 28, 2024 16:04
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants