-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1617349: Add aliases for format options to dataframe reader and writer #2155
SNOW-1617349: Add aliases for format options to dataframe reader and writer #2155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functionallity between read and write looks the same, but done in a two similar, but different ways. It might be worthwhile to extract this to a utils function to keep things dry and to make sure the error message remains consistent between the two in the future.
Yeah. They are very similar. I added a util function to deduplicate the work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with one minor comment.
def get_aliased_option_name( | ||
key: str, | ||
alias_map: Dict[str, str], | ||
) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. added
…option-discrepency-with-pyspark
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1617349
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR adds reader and writer option aliases to help with migration. One pager about this change is here: https://docs.google.com/document/d/1U-VucApRuC74RsPEvZ5HUzqZf1NluintZ8z1Nl7fI2w/edit