SNOW-1636767, SNOW-1635405: Support timestamp +/- timedelta. #2153
+648
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
sfc-gh-mvashishtha
added
the
NO-PANDAS-CHANGEDOC-UPDATES
sfc-gh-mvashishtha
requested review from
sfc-gh-dpetersohn,
sfc-gh-jkew,
sfc-gh-azhan and
sfc-gh-nkrishna
and removed request for
sfc-gh-dpetersohn and
sfc-gh-jkew
src/snowflake/snowpark/modin/plugin/_internal/binary_op_utils.py
Outdated
Show resolved
Hide resolved
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Co-authored-by: Andong Zhan <[email protected]>
…t-timestamp-plus-or-minus-timedelta
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
@sfc-gh-azhan The new timedelta integration tests in /Users/mvashishtha/sources/snowpark-python/tests/integ/modin/binary/test_binary_op.py showed that we were not raising |
…t-timestamp-plus-or-minus-timedelta
sfc-gh-azhan
approved these changes
Aug 23, 2024
sfc-gh-mvashishtha
deleted the
mvashishtha/SNOW-1636767-SNOW-1635405-support-timestamp-plus-or-minus-timedelta
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SNOW-1636767
Fixes SNOW-1635405