-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1625368 SNOW-1634393 Support indexing with Timedelta data columns #2141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments.
src/snowflake/snowpark/modin/plugin/_internal/snowpark_pandas_types.py
Outdated
Show resolved
Hide resolved
f5536b0
to
684a8af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice :)
7f045aa
to
1ce1d99
Compare
@sfc-gh-azhan I restarted CI on this pr because I assumed it was a flake, but it looks legitimate: https://github.com/snowflakedb/snowpark-python/actions/runs/10512030861/job/29124497386?pr=2141 |
It was a window specific failure. Fixed. |
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
SNOW-1625368 Support indexing with Timedelta data columns
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
Support indexing with Timedelta data columns:
SnowparkPandasType
since there are some confusing ontype
object and class there.This pull request includes several changes to enhance support for
Timedelta
and improve type safety in the Snowflake Snowpark Modin plugin. The most important changes are summarized below:Enhancements to Timedelta Support:
Timedelta
data columns. (CHANGELOG.md
: CHANGELOG.mdR30-L37)Type Safety Improvements:
data_column_types
andindex_column_types
are instances ofSnowparkPandasType
in_create_snowflake_quoted_identifier_to_snowpark_pandas_type
. (src/snowflake/snowpark/modin/plugin/_internal/frame.py
: src/snowflake/snowpark/modin/plugin/_internal/frame.pyR92-R106)project_columns
to include an optionalcolumn_types
parameter and ensure its length matchespandas_labels
. (src/snowflake/snowpark/modin/plugin/_internal/frame.py
: [1] [2] [3]set_frame_2d_labels
andset_frame_2d_positional
to handleSnowparkPandasColumn
andSnowparkPandasType
correctly. (src/snowflake/snowpark/modin/plugin/_internal/indexing_utils.py
: [1] [2] [3] [4] [5] [6]get_item_series_as_single_row_frame
to includeSnowparkPandasType
. (src/snowflake/snowpark/modin/plugin/_internal/indexing_utils.py
: src/snowflake/snowpark/modin/plugin/_internal/indexing_utils.pyR3065)_create_internal_frame_with_join_or_align_result
to handledata_column_types
andindex_column_types
during joins. (src/snowflake/snowpark/modin/plugin/_internal/join_utils.py
: [1] [2] [3]