SNOW-1625830: Fix circular import when calling to_snowpark_pandas without initializing Snowpark pandas
#2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-joshi
requested review from
sfc-gh-smirzaei,
sfc-gh-aalam and
sfc-gh-jrose
sfc-gh-joshi
changed the title
to_snowpark_pandas without initializing Snowpark pandasto_snowpark_pandas without initializing Snowpark pandas
sfc-gh-yzou
reviewed
Aug 15, 2024
sfc-gh-yzou
reviewed
Aug 16, 2024
|
@sfc-gh-joshi it seems your test is failing, can you take a look? can you also start the snowpark python daily test for this change |
sfc-gh-joshi
force-pushed
the
joshi-SNOW-1625380-to_snowpark_pandas-import
branch
from
195ba0a to
cbd3d28
Compare
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
1 similar comment
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
7 tasks
|
Daily job run in progress: #2132 |
sfc-gh-mvashishtha
approved these changes
Aug 21, 2024
sfc-gh-yzou
approved these changes
Aug 21, 2024
sfc-gh-yuwang
approved these changes
Aug 26, 2024
sfc-gh-helmeleegy
approved these changes
Aug 26, 2024
sfc-gh-joshi
force-pushed
the
joshi-SNOW-1625380-to_snowpark_pandas-import
branch
from
4457539 to
660365c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1625830
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Calling
to_snowpark_pandason a Snowpark Python DataFrame without first performingimport snowflake.snowpark.modin.plugincurrently raises an error (see attached JIRA for exact reproduction). This was not the case in previous releases, and this PR fixes internal imports such that performing this operation implicitly initializes Snowpark pandas.After this PR, when
to_snowpark_pandasis called without explicitly initializing Snowpark pandas, one of two things happens:This is the same error as if the user had tried to
import snowflake.snowpark.modin.pluginwithout installing the modin dependency.import snowflake.snowpark.modin.plugin. If the user performsimport modin.pandas as pdafterwards, the modin namespace will be set up with Snowpark pandas behavior.