Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1486910: Return DatetimeIndex from to_datetime and date_range #2050

Merged
merged 4 commits into from
Aug 12, 2024
Merged

SNOW-1486910: Return DatetimeIndex from to_datetime and date_range #2050

merged 4 commits into from
Aug 12, 2024

Conversation

sfc-gh-nkumar
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1486910

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    Return DatetimeIndex from pd.to_datetime and pd.date_range methods.

@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-1486910-to-datetime branch from e9be01e to a88a2ab Compare August 9, 2024 00:02
@sfc-gh-nkumar sfc-gh-nkumar marked this pull request as ready for review August 9, 2024 00:03
@sfc-gh-nkumar sfc-gh-nkumar requested a review from a team as a code owner August 9, 2024 00:03
@sfc-gh-nkumar sfc-gh-nkumar added the NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs label Aug 9, 2024
sfc-gh-helmeleegy
sfc-gh-helmeleegy reviewed Aug 9, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you also update the relevant doctests under the docstrings/ directory? Some doctests are currently skipped because they return DatetimeIndex.

@sfc-gh-nkumar
Copy link
Contributor Author

Looks good. Can you also update the relevant doctests under the docstrings/ directory? Some doctests are currently skipped because they return DatetimeIndex.

Updated doctests. There are few still skipped which will be fixed in next PR (SNOW-1558888) which will add support for datetime properties.

sfc-gh-helmeleegy
sfc-gh-helmeleegy approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank!

sfc-gh-azhan
sfc-gh-azhan reviewed Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-azhan sfc-gh-azhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Please rebase and make sure all tests pass.

Also can you search SNOW-1486910 in the whole code path, there are some TODO can be resolved with your change.

src/snowflake/snowpark/modin/pandas/general.py Show resolved Hide resolved
src/snowflake/snowpark/modin/pandas/general.py Outdated Show resolved Hide resolved
src/snowflake/snowpark/modin/plugin/extensions/index.py Outdated Show resolved Hide resolved
@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-1486910-to-datetime branch from 8fa287b to c7b6db6 Compare August 9, 2024 19:20
@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-1486910-to-datetime branch 2 times, most recently from 39d729a to 3824fb6 Compare August 9, 2024 22:28
@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-1486910-to-datetime branch from 3824fb6 to 159c81b Compare August 10, 2024 00:22
@sfc-gh-nkumar
Copy link
Contributor Author

Nice work! Please rebase and make sure all tests pass.

Also can you search SNOW-1486910 in the whole code path, there are some TODO can be resolved with your change.

Done

@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-1486910-to-datetime branch from ca1cd72 to 27104c7 Compare August 12, 2024 17:53
sfc-gh-azhan
sfc-gh-azhan approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-azhan sfc-gh-azhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

src/snowflake/snowpark/modin/plugin/extensions/index.py Show resolved Hide resolved
@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-1486910-to-datetime branch from 27104c7 to d50dba6 Compare August 12, 2024 17:57
@sfc-gh-nkumar sfc-gh-nkumar merged commit 619feae into main Aug 12, 2024
35 checks passed
@sfc-gh-nkumar sfc-gh-nkumar deleted the nkumar-SNOW-1486910-to-datetime branch August 12, 2024 18:29
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-azhan sfc-gh-azhan sfc-gh-azhan approved these changes

@sfc-gh-jkew sfc-gh-jkew Awaiting requested review from sfc-gh-jkew sfc-gh-jkew is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

Assignees
No one assigned
Labels
NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-nkumar @sfc-gh-azhan @sfc-gh-helmeleegy