-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix opentelemetry test #2043
Fix opentelemetry test #2043
Conversation
After consideration, I decided to move tests to integ test and remove redundant tests |
I really doubt it is cause by the pr linked there, because that pr seems just adding a function that is not called by anyone. Also, the test actually seems flaky to me, I see sometimes it fails on windows, sometime on azure etc. if it is caused by that pr. If moving the test can make it stable, we can do that. |
I am also not sure what exactly caused it, the past daily precommit before that PR seems to be stable. I found it really hard to debug this flakiness because it only appears in daily precommit. So I just move all of them to integ test because that has always been stable, I also made sure that our code coverage does not drop |
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
snowpark daily precommit pipeline was broken because of opentelemetry test.
There is no recent change of opentelemetry and the precommit test started to fail since SNOW-1557229: Add method to replace child for LogicalPlan and derivatives #1987, the root cause is still mysterious to me, but I don't think we should spend a lot of time on digging it, so I moved them to integ test and removed redundant tests. I have confirmed that our code coverage is not affected.
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.