Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opentelemetry test #2043

Merged
merged 9 commits into from
Aug 8, 2024
Merged

Fix opentelemetry test #2043

merged 9 commits into from
Aug 8, 2024

Conversation

sfc-gh-yuwang
Copy link
Collaborator

@sfc-gh-yuwang sfc-gh-yuwang commented Aug 7, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    snowpark daily precommit pipeline was broken because of opentelemetry test.
    There is no recent change of opentelemetry and the precommit test started to fail since SNOW-1557229: Add method to replace child for LogicalPlan and derivatives #1987, the root cause is still mysterious to me, but I don't think we should spend a lot of time on digging it, so I moved them to integ test and removed redundant tests. I have confirmed that our code coverage is not affected.

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-yuwang sfc-gh-yuwang added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Aug 7, 2024
@sfc-gh-yuwang
Copy link
Collaborator Author

After consideration, I decided to move tests to integ test and remove redundant tests

@sfc-gh-yuwang sfc-gh-yuwang marked this pull request as ready for review August 8, 2024 16:32
@sfc-gh-yuwang sfc-gh-yuwang requested a review from a team as a code owner August 8, 2024 16:32
@sfc-gh-yzou
Copy link
Collaborator

I really doubt it is cause by the pr linked there, because that pr seems just adding a function that is not called by anyone. Also, the test actually seems flaky to me, I see sometimes it fails on windows, sometime on azure etc. if it is caused by that pr. If moving the test can make it stable, we can do that.

@sfc-gh-yuwang sfc-gh-yuwang merged commit 4c5cd95 into main Aug 8, 2024
83 of 89 checks passed
@sfc-gh-yuwang sfc-gh-yuwang deleted the yuwang-fix-opente branch August 8, 2024 20:05
@sfc-gh-yuwang
Copy link
Collaborator Author

I really doubt it is cause by the pr linked there, because that pr seems just adding a function that is not called by anyone. Also, the test actually seems flaky to me, I see sometimes it fails on windows, sometime on azure etc. if it is caused by that pr. If moving the test can make it stable, we can do that.

I am also not sure what exactly caused it, the past daily precommit before that PR seems to be stable. I found it really hard to debug this flakiness because it only appears in daily precommit. So I just move all of them to integ test because that has always been stable, I also made sure that our code coverage does not drop

@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants