-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1478684: Remove index.equals workaround from compare #1972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Should we also remove this workaround for the bug:
snowpark-python/src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Lines 15947 to 15951 in 3e34c76
# TODO(SNOW-1478684): Stop calling to_pandas() to work around Index.equals() bug. | |
def pandas_index(index: Union[native_pd.Index, pd.Index]) -> native_pd.Index: | |
if isinstance(index, native_pd.Index): | |
return index | |
return index.to_pandas() |
ce87759
to
49338df
Compare
Done! |
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1478684
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This bug is no longer reproducible. Possibly due to recent changes in Index.equals (https://snowflakecomputing.atlassian.net/browse/SNOW-1458148). This PR adds the new test as validation before closing the issue.