Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNOW-1551115] Fix test failure for test_execution_queries_and_queries when sql_simplifier is disabled #1960

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

sfc-gh-yzou
Copy link
Collaborator

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

SNOW-1551115

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  2. Please describe how your code solves the related issue.

test_execution_queries_and_queries is failing when sql simplifier is disabled because the cte optimization actually didn't kick in. update test to verify the result based on the sql simplifier configuration

@sfc-gh-yzou sfc-gh-yzou requested a review from a team as a code owner July 23, 2024 01:10
@sfc-gh-yzou sfc-gh-yzou added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jul 23, 2024
@sfc-gh-yzou
Copy link
Collaborator Author

@sfc-gh-jdu comment with todo added

@sfc-gh-yzou sfc-gh-yzou merged commit 1cc5a03 into main Jul 23, 2024
34 checks passed
@sfc-gh-yzou sfc-gh-yzou deleted the yzou-SNOW-1551115-fix-test-failure branch July 23, 2024 21:24
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants