Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNOW-1524894]: Add support for reindex #1893

Merged
merged 22 commits into from
Jul 15, 2024
Merged

Conversation

sfc-gh-rdurrani
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1524894

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

Add support for reindex.

@sfc-gh-rdurrani sfc-gh-rdurrani marked this pull request as ready for review July 11, 2024 04:40
@sfc-gh-helmeleegy
Copy link
Contributor

The to_csv fix is already in. So if you merge with main, you should be able to get rid of some of the test failures.

Copy link
Contributor

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I missed it, do we have negative MultiIndex tests for frame/series here?

tests/integ/modin/frame/test_reindex.py Show resolved Hide resolved
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the nice refactoring, the comments with all the clarifying examples and the thorough test coverage. Great job!

@sfc-gh-rdurrani sfc-gh-rdurrani enabled auto-merge (squash) July 15, 2024 21:29
Copy link
Contributor

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sfc-gh-rdurrani sfc-gh-rdurrani merged commit d1f5e16 into main Jul 15, 2024
34 checks passed
@sfc-gh-rdurrani sfc-gh-rdurrani deleted the rdurrani-SNOW-1524894 branch July 15, 2024 23:51
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants