Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1344938: Add support for DataFrame.corr #1857

Merged
merged 4 commits into from
Jul 1, 2024
Merged

SNOW-1344938: Add support for DataFrame.corr #1857

merged 4 commits into from
Jul 1, 2024

Conversation

sfc-gh-helmeleegy
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy commented Jun 28, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1344938

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    Add support for DataFrame.corr.

@sfc-gh-helmeleegy sfc-gh-helmeleegy requested a review from a team as a code owner June 28, 2024 20:39
sfc-gh-nkrishna
sfc-gh-nkrishna reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't taken a close look, but I'm wondering if some of this can be moved to aggregation_utils.py so as to be reused for groupby/resample/window functions?

sfc-gh-jkew
sfc-gh-jkew approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-jkew sfc-gh-jkew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good. Easy to read, tests covered the issues I was thinking of.

@sfc-gh-helmeleegy
Copy link
Contributor Author

Haven't taken a close look, but I'm wondering if some of this can be moved to aggregation_utils.py so as to be reused for groupby/resample/window functions?

Yes, that's a good point. I haven't thought thoroughly about the corresponding implementation for groupby/resmaple/window. So I'd suggest to just keep the refactoring (if any) for when we start adding those other implementations.

@sfc-gh-helmeleegy
Copy link
Contributor Author

@sfc-gh-nkrishna I think it's ready for re-review now.

sfc-gh-nkrishna
sfc-gh-nkrishna approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left one suggestion!

tests/integ/modin/frame/test_aggregate.py Outdated Show resolved Hide resolved
@sfc-gh-helmeleegy sfc-gh-helmeleegy enabled auto-merge (squash) July 1, 2024 20:15
@sfc-gh-helmeleegy sfc-gh-helmeleegy merged commit 8a42763 into main Jul 1, 2024
35 checks passed
@sfc-gh-helmeleegy sfc-gh-helmeleegy deleted the helmeleegy-SNOW-1344938 branch July 1, 2024 20:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jkew sfc-gh-jkew sfc-gh-jkew approved these changes

@sfc-gh-nkrishna sfc-gh-nkrishna sfc-gh-nkrishna approved these changes

Assignees
No one assigned
Labels
snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-helmeleegy @sfc-gh-nkrishna @sfc-gh-jkew