Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNOW-1502893]: Add support for pd.crosstab #1837

Merged
merged 32 commits into from
Aug 31, 2024
Merged

[SNOW-1502893]: Add support for pd.crosstab #1837

merged 32 commits into from
Aug 31, 2024

Conversation

sfc-gh-rdurrani
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1502893

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

Add support for pd.crosstab.

@sfc-gh-rdurrani sfc-gh-rdurrani requested a review from a team as a code owner June 25, 2024 23:02
@sfc-gh-rdurrani sfc-gh-rdurrani marked this pull request as draft June 25, 2024 23:02
@sfc-gh-helmeleegy
Copy link
Contributor

Tests?

@sfc-gh-rdurrani sfc-gh-rdurrani marked this pull request as ready for review August 21, 2024 23:54
sfc-gh-mvashishtha
sfc-gh-mvashishtha reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-mvashishtha sfc-gh-mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving minor comments on just the test file.

tests/integ/modin/crosstab/__init__.py Outdated Show resolved Hide resolved
tests/integ/modin/crosstab/test_crosstab.py Outdated Show resolved Hide resolved
tests/integ/modin/crosstab/test_crosstab.py Outdated Show resolved Hide resolved
tests/integ/modin/crosstab/test_crosstab.py Outdated Show resolved Hide resolved
tests/integ/modin/crosstab/test_crosstab.py Outdated Show resolved Hide resolved
tests/integ/modin/crosstab/test_crosstab.py Show resolved Hide resolved
tests/integ/modin/crosstab/test_crosstab.py Outdated Show resolved Hide resolved
tests/integ/modin/crosstab/test_crosstab.py Outdated Show resolved Hide resolved
sfc-gh-mvashishtha
sfc-gh-mvashishtha reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-mvashishtha sfc-gh-mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed all the files

src/snowflake/snowpark/modin/pandas/base.py Outdated Show resolved Hide resolved
src/snowflake/snowpark/modin/pandas/general.py Show resolved Hide resolved
sfc-gh-helmeleegy
sfc-gh-helmeleegy approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Rehan!

@sfc-gh-helmeleegy
Copy link
Contributor

Tests?

This is already covered.

@sfc-gh-rdurrani sfc-gh-rdurrani enabled auto-merge (squash) August 30, 2024 00:40
@sfc-gh-rdurrani sfc-gh-rdurrani merged commit 3c1db07 into main Aug 31, 2024
35 checks passed
@sfc-gh-rdurrani sfc-gh-rdurrani deleted the rdurrani-SNOW-1502893 branch August 31, 2024 00:15
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-mvashishtha sfc-gh-mvashishtha sfc-gh-mvashishtha approved these changes

@sfc-gh-joshi sfc-gh-joshi Awaiting requested review from sfc-gh-joshi sfc-gh-joshi is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

Assignees
No one assigned
Labels
snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-rdurrani @sfc-gh-helmeleegy @sfc-gh-mvashishtha