Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1478188 CI: xfail three apply tests due to sql count diff in pre… #1765

Merged
merged 1 commit into from
Jun 12, 2024
Merged

SNOW-1478188 CI: xfail three apply tests due to sql count diff in pre… #1765

merged 1 commit into from
Jun 12, 2024

Conversation

sfc-gh-azhan
Copy link
Collaborator

…prod

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1478188

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-azhan sfc-gh-azhan requested a review from a team as a code owner June 12, 2024 20:13
@sfc-gh-azhan sfc-gh-azhan added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs and removed snowpark-pandas labels Jun 12, 2024
@sfc-gh-azhan sfc-gh-azhan merged commit cf2d4e7 into main Jun 12, 2024
35 of 37 checks passed
@sfc-gh-azhan sfc-gh-azhan deleted the azhan-fix-1478188 branch June 12, 2024 22:02
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
@sfc-gh-evandenberg
Copy link
Collaborator

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-nkrishna sfc-gh-nkrishna sfc-gh-nkrishna approved these changes

@sfc-gh-vbudati sfc-gh-vbudati sfc-gh-vbudati approved these changes

@sfc-gh-joshi sfc-gh-joshi Awaiting requested review from sfc-gh-joshi sfc-gh-joshi is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-helmeleegy sfc-gh-helmeleegy Awaiting requested review from sfc-gh-helmeleegy sfc-gh-helmeleegy is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-azhan @sfc-gh-evandenberg @sfc-gh-vbudati @sfc-gh-nkrishna