Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto PR labeler for local testing label #1718

Merged
merged 1 commit into from
May 31, 2024
Merged

Add auto PR labeler for local testing label #1718

merged 1 commit into from
May 31, 2024

Conversation

sfc-gh-stan
Copy link
Collaborator

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-stan sfc-gh-stan requested review from a team as code owners May 31, 2024 21:07
@sfc-gh-stan sfc-gh-stan added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label May 31, 2024
sfc-gh-nkrishna
sfc-gh-nkrishna approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not know we had a labeler.yml (super convenient!), thoughts on doing this for the snowpark-pandas label too cc @sfc-gh-rdurrani @sfc-gh-azhan?

@sfc-gh-rdurrani
Copy link
Contributor

sfc-gh-rdurrani commented May 31, 2024 •
edited
Loading

Did not know we had a labeler.yml (super convenient!), thoughts on doing this for the snowpark-pandas label too cc @sfc-gh-rdurrani @sfc-gh-azhan?

This PR builds on a PR I previously merged that introduced the labeler.yml action and added the snowpark-pandas label: #1667

@sfc-gh-stan sfc-gh-stan merged commit 9b32aa7 into main May 31, 2024
34 of 35 checks passed
@sfc-gh-stan sfc-gh-stan deleted the stan-auto-label-local-testing branch May 31, 2024 21:59
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jrose sfc-gh-jrose sfc-gh-jrose approved these changes

@sfc-gh-nkrishna sfc-gh-nkrishna sfc-gh-nkrishna approved these changes

@sfc-gh-joshi sfc-gh-joshi Awaiting requested review from sfc-gh-joshi sfc-gh-joshi is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-helmeleegy sfc-gh-helmeleegy Awaiting requested review from sfc-gh-helmeleegy sfc-gh-helmeleegy is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-stan @sfc-gh-rdurrani @sfc-gh-nkrishna @sfc-gh-jrose