Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1374013: local testing fix dataframe time parse precision error #1599

Merged
merged 7 commits into from
May 21, 2024
Merged

SNOW-1374013: local testing fix dataframe time parse precision error #1599

merged 7 commits into from
May 21, 2024

Conversation

sfc-gh-aling
Copy link
Contributor

@sfc-gh-aling sfc-gh-aling commented May 16, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

this PR does two things:

  1. fix a bug in fractional second when parsing input value for time and timestamp data, previously it leads to index error
  2. align with the snowflake behavior when handling time/timestamp format as input, snowflake doesn't appreciate fractional seconds in the format, always use nanoseconds

@sfc-gh-aling sfc-gh-aling added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label May 16, 2024
@sfc-gh-aling sfc-gh-aling marked this pull request as ready for review May 16, 2024 17:39
@sfc-gh-aling sfc-gh-aling requested a review from a team as a code owner May 16, 2024 17:39
@sfc-gh-aling sfc-gh-aling added the local testing Local Testing issues/PRs label May 16, 2024
sfc-gh-jrose
sfc-gh-jrose approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-jrose sfc-gh-jrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting find. That behavior for live mode seems incorrect. Should we raise a bug with the sql team?

@sfc-gh-aling
Copy link
Contributor Author

sfc-gh-aling commented May 17, 2024 •
edited
Loading

@sfc-gh-jrose , yes,I asked sql team about this behavior, haven't heard response yet

@sfc-gh-aling sfc-gh-aling removed the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label May 17, 2024
@sfc-gh-aling sfc-gh-aling merged commit 74aaf84 into main May 21, 2024
31 of 32 checks passed
@sfc-gh-aling sfc-gh-aling deleted the SNOW-1374013-bug-create-dataframe-time-parse-failure branch May 21, 2024 23:40
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jrose sfc-gh-jrose sfc-gh-jrose approved these changes

@sfc-gh-stan sfc-gh-stan sfc-gh-stan approved these changes

@sfc-gh-aalam sfc-gh-aalam Awaiting requested review from sfc-gh-aalam sfc-gh-aalam is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
local testing Local Testing issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-aling @sfc-gh-stan @sfc-gh-jrose