Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1413958: Skip optimizing dynamic pivot query plan using CTE #1571

Merged
merged 2 commits into from
May 14, 2024
Merged

SNOW-1413958: Skip optimizing dynamic pivot query plan using CTE #1571

merged 2 commits into from
May 14, 2024

Conversation

sfc-gh-jdu
Copy link
Collaborator

@sfc-gh-jdu sfc-gh-jdu commented May 14, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1413958

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Due to https://snowflakecomputing.atlassian.net/browse/SNOW-1375062, we need to skip optimizing dynamic pivot query plan using CTE. Specifically, any subquery under dynamic pivot plan will not be converted to a CTE.

@sfc-gh-jdu sfc-gh-jdu requested a review from a team as a code owner May 14, 2024 01:26
@sfc-gh-jdu sfc-gh-jdu requested a review from sfc-gh-sfan May 14, 2024 01:26
@sfc-gh-helmeleegy
Copy link
Contributor

Fixes SNOW-NNNNNNN
Please update.

sfc-gh-helmeleegy
sfc-gh-helmeleegy approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix!

@sfc-gh-jdu sfc-gh-jdu added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label May 14, 2024
@sfc-gh-jdu
Copy link
Collaborator Author

Fixes SNOW-NNNNNNN
Please update.

done

@sfc-gh-jdu sfc-gh-jdu enabled auto-merge (squash) May 14, 2024 17:39
@sfc-gh-jdu sfc-gh-jdu merged commit 6336e38 into main May 14, 2024
33 of 34 checks passed
@sfc-gh-jdu sfc-gh-jdu deleted the jdu-cte-dynamic-pivot branch May 14, 2024 18:45
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie

@sfc-gh-sfan sfc-gh-sfan Awaiting requested review from sfc-gh-sfan sfc-gh-sfan is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jdu @sfc-gh-helmeleegy @sfc-gh-aalam