-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1359484 Allow write Snowpark pandas DataFrame and Series in sess… #1563
Conversation
1d3d78e
to
972bceb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall. Just a few minor nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for taking care of this!
d66dc4c
to
ae083e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have a test that validates the naming conventions as well to make sure the quote_id code paths are working correctly.
It's also surprising to me that new functionality would not require a CHANGELOG update.
I have integ tests to cover the case where quote_id is true or false, and the code is basically the same as the existing code: snowpark-python/src/snowflake/snowpark/session.py Line 2219 in cc3d289
|
ae083e8
to
25f6064
Compare
…ion.write_pandas
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1359484
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
Allow user to use
session.write_pandas
to write Snowpark pandas objects:write_pandas
to_snowflake
to implement the write logictest_pandas_to_df.py
and use them to test writing Snowpark pandas DataFrame.