[DRAFT] Packaging snowpark-python as .pex module for server-side deployment #1543
+740
−3,105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup.py
Outdated
| @@ -103,6 +104,8 @@ | |||
| "snowflake.snowpark.modin.plugin.extensions", | |||
| "snowflake.snowpark.modin.plugin.io", | |||
| "snowflake.snowpark.modin.plugin.utils", | |||
| "snowflake.snowpark._internal.tcm", | |||
There was a problem hiding this comment.
should be contiguous with the prior _internal section (and sorted)
| # Copyright (c) 2012-2024 Snowflake Computing Inc. All rights reserved. | ||
| # | ||
|
|
||
| # evaluate AST given as base64 encoded protobuf |
There was a problem hiding this comment.
Sounds like a doc comment for process_ast
| } |
There was a problem hiding this comment.
this is a generated file. cool if ir-dsl-c is updated so that this diff is a result of running ast-make.sh.
|
Probably the most important comment: all TCM work should be done in the monorepo's clone of the Python client – in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.