SNOW-1300150:Automatic schema inference for CSV loading option unclear #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-yuwang
force-pushed
the
SNOW-1300150
branch
from
0ceb10f to
c1471fd
Compare
|
In this PR, we only set default infer_schema as true when reading csv file. If we do this to json file, there is a breaking change |
sfc-gh-yixie
reviewed
May 7, 2024
sfc-gh-aalam
approved these changes
May 8, 2024
| @@ -421,6 +418,7 @@ def csv(self, path: str) -> DataFrame: | |||
| schema_to_cast = [("$1", "C1")] | |||
| transformations = [] | |||
| else: | |||
| self._cur_options["INFER_SCHEMA"] = False | |||
There was a problem hiding this comment.
this condition will already be true if we reach the else branch, right?
There was a problem hiding this comment.
No, if we reach here, user must have provide a schema, in that way, we should use what user provide and turn off infer_schema
CHANGELOG.md
Outdated
Comment on lines
7
to
8
| - Improved error message to remind users set `{"infer_schema":True}` when read csv file without specifying its schema.ß | ||
|
|
There was a problem hiding this comment.
Suggested change
| - Improved error message to remind users set `{"infer_schema":True}` when read csv file without specifying its schema.ß | |
| - Improved error message to remind users set `{"infer_schema": True}` when reading csv file without specifying its schema. | |
nit
sfc-gh-yixie
reviewed
May 9, 2024
sfc-gh-yixie
approved these changes
May 9, 2024
sfc-gh-jrose
approved these changes
May 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1300150
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.